Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1088)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 596323002: DevTools: make ElementsTreeOutline shadow dom-based. (Closed)

Created:
6 years, 3 months ago by pfeldman
Modified:
6 years, 2 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: make ElementsTreeOutline shadow dom-based. NOTRY=true BUG=417275 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183724

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebaselined #

Patch Set 4 : tests fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+447 lines, -226 lines) Patch
M LayoutTests/http/tests/inspector/console-test.js View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/audits/audits-test.js View 1 2 3 1 chunk +5 lines, -3 lines 0 comments Download
M LayoutTests/inspector/elements/edit-dom-test.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/extensions/extensions-audits-content-script-expected.txt View 1 2 3 2 chunks +24 lines, -16 lines 0 comments Download
M LayoutTests/inspector/extensions/extensions-audits-expected.txt View 1 2 3 1 chunk +12 lines, -8 lines 0 comments Download
M Source/devtools/devtools.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/elements/ElementsPanel.js View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/elements/ElementsTreeOutline.js View 1 2 3 9 chunks +29 lines, -25 lines 0 comments Download
M Source/devtools/front_end/elementsPanel.css View 1 2 3 4 chunks +1 line, -78 lines 0 comments Download
A Source/devtools/front_end/elementsTreeOutline.css View 1 2 3 1 chunk +259 lines, -0 lines 0 comments Download
M Source/devtools/front_end/inspectorCommon.css View 1 2 3 2 chunks +53 lines, -20 lines 0 comments Download
M Source/devtools/front_end/inspectorStyle.css View 1 2 2 chunks +0 lines, -30 lines 0 comments Download
M Source/devtools/front_end/inspectorSyntaxHighlight.css View 1 2 1 chunk +37 lines, -37 lines 0 comments Download
M Source/devtools/front_end/ui/DOMExtension.js View 1 2 3 2 chunks +22 lines, -4 lines 0 comments Download
M Source/devtools/front_end/ui/RootView.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
pfeldman
PTAL
6 years, 2 months ago (2014-10-13 15:57:20 UTC) #2
apavlov
lgtm
6 years, 2 months ago (2014-10-14 11:39:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596323002/140001
6 years, 2 months ago (2014-10-14 16:27:07 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/31750)
6 years, 2 months ago (2014-10-14 18:44:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596323002/140001
6 years, 2 months ago (2014-10-15 03:52:04 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/31842)
6 years, 2 months ago (2014-10-15 06:11:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596323002/140001
6 years, 2 months ago (2014-10-15 06:26:12 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 06:26:48 UTC) #15
Message was sent while issue was closed. 
Committed patchset #4 (id:140001) as 183724

Powered by Google App Engine
This is Rietveld 408576698