Move painting code from RenderReplaced to ReplacedPainter.

Source/core/rendering/RenderReplaced.h

Index: Source/core/rendering/RenderReplaced.h
diff --git a/Source/core/rendering/RenderReplaced.h b/Source/core/rendering/RenderReplaced.h
index a8b998a25d9a226a48b969bcfc2234f64544efef..c8179fdaf5e71f560d346281e95a7e4c6118d2e1 100644
--- a/Source/core/rendering/RenderReplaced.h
+++ b/Source/core/rendering/RenderReplaced.h
@@ -44,6 +44,10 @@ public:
     // http://www.w3.org/TR/CSS2/visudet.html#inline-replaced-width
     static const int defaultWidth;
     static const int defaultHeight;
+    virtual bool canHaveChildren() const OVERRIDE { return false; }

[pdr., 2014/09/24 16:57:20]

Did you need this?

[chrishtr, 2014/09/25 16:36:40]

Line 40 of ReplacedPainter calls it.

+    bool shouldPaint(PaintInfo&, const LayoutPoint&);
+    virtual void paintReplaced(PaintInfo&, const LayoutPoint&) { }
+    LayoutRect localSelectionRect(bool checkWhetherSelected = true) const; // This is in local coordinates, but it's a physical rect (so the top left corner is physical top left).
 
 protected:
     virtual void willBeDestroyed() OVERRIDE;
@@ -69,17 +73,12 @@ protected:
     virtual void intrinsicSizeChanged();
 
     virtual void paint(PaintInfo&, const LayoutPoint&) OVERRIDE;
-    bool shouldPaint(PaintInfo&, const LayoutPoint&);
-    LayoutRect localSelectionRect(bool checkWhetherSelected = true) const; // This is in local coordinates, but it's a physical rect (so the top left corner is physical top left).
     virtual RenderBox* embeddedContentBox() const { return 0; }
 
 private:
     virtual const char* renderName() const OVERRIDE { return "RenderReplaced"; }
 
-    virtual bool canHaveChildren() const OVERRIDE { return false; }
-
     virtual void computePreferredLogicalWidths() OVERRIDE FINAL;
-    virtual void paintReplaced(PaintInfo&, const LayoutPoint&) { }
 
     virtual LayoutRect clippedOverflowRectForPaintInvalidation(const RenderLayerModelObject* paintInvalidationContainer, const PaintInvalidationState* = 0) const OVERRIDE;