Move painting code from RenderReplaced to ReplacedPainter.

Move painting code from RenderReplaced to ReplacedPainter.

BUG=412088
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182801

[chrishtr, 2014-09-24 16:54:34]

chrishtr@chromium.org changed reviewers:
+ pdr@chromium.org

[pdr., 2014-09-24 16:57:20]

https://codereview.chromium.org/596313004/diff/40001/Source/core/rendering/Re...
File Source/core/rendering/RenderReplaced.h (right):

https://codereview.chromium.org/596313004/diff/40001/Source/core/rendering/Re...
Source/core/rendering/RenderReplaced.h:47: virtual bool canHaveChildren() const
OVERRIDE { return false; }
Did you need this?

[chrishtr, 2014-09-25 16:36:41]

https://codereview.chromium.org/596313004/diff/40001/Source/core/rendering/Re...
File Source/core/rendering/RenderReplaced.h (right):

https://codereview.chromium.org/596313004/diff/40001/Source/core/rendering/Re...
Source/core/rendering/RenderReplaced.h:47: virtual bool canHaveChildren() const
OVERRIDE { return false; }
On 2014/09/24 at 16:57:20, pdr wrote:
> Did you need this?

Line 40 of ReplacedPainter calls it.

[pdr., 2014-09-25 17:26:54]

LGTM

[chrishtr, 2014-09-25 17:30:40]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2014-09-25 17:31:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/596313004/40001

[commit-bot: I haz the power, 2014-09-25 17:31:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-25 17:31:55]

Failed to apply patch for Source/core/core.gypi:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/core.gypi
  Hunk #1 FAILED at 1513.
  1 out of 1 hunk FAILED -- saving rejects to file Source/core/core.gypi.rej

Patch:       Source/core/core.gypi
Index: Source/core/core.gypi
diff --git a/Source/core/core.gypi b/Source/core/core.gypi
index
f98c9e350442348cdb16e2877bd12da4b9eafdb5..8545b3dea58bec6cdc4c5b5ca98ad131f78b466a
100644
--- a/Source/core/core.gypi
+++ b/Source/core/core.gypi
@@ -1513,6 +1513,8 @@
             'paint/ListItemPainter.h',
             'paint/ObjectPainter.cpp',
             'paint/ObjectPainter.h',
+            'paint/ReplacedPainter.cpp',
+            'paint/ReplacedPainter.h',
             'paint/SVGForeignObjectPainter.cpp',
             'paint/SVGForeignObjectPainter.h',
             'paint/TablePainter.cpp',

[chrishtr, 2014-09-25 17:51:20]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2014-09-25 17:52:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/596313004/100001

[commit-bot: I haz the power, 2014-09-25 18:01:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-25 18:01:27]

Try jobs failed on following builders:
  mac_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)

[chrishtr, 2014-09-25 18:04:58]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2014-09-25 18:06:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/596313004/120001

[commit-bot: I haz the power, 2014-09-25 23:12:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-25 23:12:49]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/28864)

[chrishtr, 2014-09-26 23:51:10]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2014-09-26 23:51:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/596313004/140001

[commit-bot: I haz the power, 2014-09-27 01:12:09]

Committed patchset #8 (id:140001) as 182801