Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: build/android/gyp/jar.py

Issue 596303002: Revert of Revert of [Android] JUnit runner + gyp changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@deps-changes
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/all.gyp ('k') | build/android/gyp/javac.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # 2 #
3 # Copyright 2013 The Chromium Authors. All rights reserved. 3 # Copyright 2013 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 import fnmatch 7 import fnmatch
8 import optparse 8 import optparse
9 import os 9 import os
10 import sys 10 import sys
11 11
12 from util import build_utils 12 from util import build_utils
13 from util import md5_check 13 from util import md5_check
14 14
15 def Jar(class_files, classes_dir, jar_path): 15
16 def Jar(class_files, classes_dir, jar_path, manifest_file=None):
16 jar_path = os.path.abspath(jar_path) 17 jar_path = os.path.abspath(jar_path)
17 18
18 # The paths of the files in the jar will be the same as they are passed in to 19 # The paths of the files in the jar will be the same as they are passed in to
19 # the command. Because of this, the command should be run in 20 # the command. Because of this, the command should be run in
20 # options.classes_dir so the .class file paths in the jar are correct. 21 # options.classes_dir so the .class file paths in the jar are correct.
21 jar_cwd = classes_dir 22 jar_cwd = classes_dir
22 class_files_rel = [os.path.relpath(f, jar_cwd) for f in class_files] 23 class_files_rel = [os.path.relpath(f, jar_cwd) for f in class_files]
23 jar_cmd = ['jar', 'cf0', jar_path] + class_files_rel 24 jar_cmd = ['jar', 'cf0', jar_path]
25 if manifest_file:
26 jar_cmd[1] += 'm'
27 jar_cmd.append(os.path.abspath(manifest_file))
28 jar_cmd.extend(class_files_rel)
24 29
25 record_path = '%s.md5.stamp' % jar_path 30 record_path = '%s.md5.stamp' % jar_path
26 md5_check.CallAndRecordIfStale( 31 md5_check.CallAndRecordIfStale(
27 lambda: build_utils.CheckOutput(jar_cmd, cwd=jar_cwd), 32 lambda: build_utils.CheckOutput(jar_cmd, cwd=jar_cwd),
28 record_path=record_path, 33 record_path=record_path,
29 input_paths=class_files, 34 input_paths=class_files,
30 input_strings=jar_cmd, 35 input_strings=jar_cmd,
31 force=not os.path.exists(jar_path), 36 force=not os.path.exists(jar_path),
32 ) 37 )
33 38
34 build_utils.Touch(jar_path, fail_if_missing=True) 39 build_utils.Touch(jar_path, fail_if_missing=True)
35 40
36 41
37 def JarDirectory(classes_dir, excluded_classes, jar_path): 42 def JarDirectory(classes_dir, excluded_classes, jar_path, manifest_file=None):
38 class_files = build_utils.FindInDirectory(classes_dir, '*.class') 43 class_files = build_utils.FindInDirectory(classes_dir, '*.class')
39 for exclude in excluded_classes: 44 for exclude in excluded_classes:
40 class_files = filter( 45 class_files = filter(
41 lambda f: not fnmatch.fnmatch(f, exclude), class_files) 46 lambda f: not fnmatch.fnmatch(f, exclude), class_files)
42 47
43 Jar(class_files, classes_dir, jar_path) 48 Jar(class_files, classes_dir, jar_path, manifest_file=manifest_file)
49
44 50
45 def main(): 51 def main():
46 parser = optparse.OptionParser() 52 parser = optparse.OptionParser()
47 parser.add_option('--classes-dir', help='Directory containing .class files.') 53 parser.add_option('--classes-dir', help='Directory containing .class files.')
48 parser.add_option('--jar-path', help='Jar output path.') 54 parser.add_option('--jar-path', help='Jar output path.')
49 parser.add_option('--excluded-classes', 55 parser.add_option('--excluded-classes',
50 help='List of .class file patterns to exclude from the jar.') 56 help='List of .class file patterns to exclude from the jar.')
51 parser.add_option('--stamp', help='Path to touch on success.') 57 parser.add_option('--stamp', help='Path to touch on success.')
52 58
53 options, _ = parser.parse_args() 59 options, _ = parser.parse_args()
54 60
61 if options.excluded_classes:
62 excluded_classes = build_utils.ParseGypList(options.excluded_classes)
63 else:
64 excluded_classes = []
55 JarDirectory(options.classes_dir, 65 JarDirectory(options.classes_dir,
56 build_utils.ParseGypList(options.excluded_classes), 66 excluded_classes,
57 options.jar_path) 67 options.jar_path)
58 68
59 if options.stamp: 69 if options.stamp:
60 build_utils.Touch(options.stamp) 70 build_utils.Touch(options.stamp)
61 71
62 72
63 if __name__ == '__main__': 73 if __name__ == '__main__':
64 sys.exit(main()) 74 sys.exit(main())
65 75
OLDNEW
« no previous file with comments | « build/all.gyp ('k') | build/android/gyp/javac.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698