Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 596303002: Revert of Revert of [Android] JUnit runner + gyp changes. (Closed)

Created:
6 years, 2 months ago by phoglund_chromium
Modified:
6 years, 2 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@deps-changes
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of [Android] JUnit runner + gyp changes. (patchset #1 id:1 of https://codereview.chromium.org/597123002/) Reason for revert: Didn't help. We probably got scheduled on other, flakier Android devices which caused tests to start flaking, or something else is the root cause. Original issue's description: > Revert of [Android] JUnit runner + gyp changes. (patchset #15 id:280001 of https://codereview.chromium.org/574433003/) > > Reason for revert: > Speculative revert: Android test started flaking a ton after this landed. Affected targets androidwebview_instrumentation_tests, chromeshell_instrumentation_tests, contentshell_instrumentation_tests. This CL seems the most likely in the blamelist of https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/15905. > > Original issue's description: > > [Android] JUnit runner + gyp changes. > > > > This adds Java code for running junit tests, as well as gyp targets for > > both runnable and non-runnable host-side JARs. > > > > BUG=316383 > > > > Committed: https://crrev.com/2e56d4508e33de5fc60bbbb41c5a5d5534e88174 > > Cr-Commit-Position: refs/heads/master@{#296340} > > TBR=cjhopman@chromium.org,nyquist@chromium.org,aurimas@chromium.org,jbudorick@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=316383 > > Committed: https://crrev.com/54b9408f8b18e3bf3a33343e375186e1949e8e86 > Cr-Commit-Position: refs/heads/master@{#296384} TBR=cjhopman@chromium.org,nyquist@chromium.org,aurimas@chromium.org,jbudorick@chromium.org NOTREECHECKS=true NOTRY=true BUG=316383 Committed: https://crrev.com/6e9dc50aecf078d7826fe8e4611b2c238aab3f23 Cr-Commit-Position: refs/heads/master@{#296406}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1288 lines, -6 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M build/android/gyp/jar.py View 4 chunks +15 lines, -5 lines 0 comments Download
M build/android/gyp/javac.py View 4 chunks +52 lines, -1 line 0 comments Download
A build/host_jar.gypi View 1 chunk +102 lines, -0 lines 0 comments Download
A build/host_prebuilt_jar.gypi View 1 chunk +50 lines, -0 lines 0 comments Download
A testing/android/junit/java/src/org/chromium/testing/local/GtestComputer.java View 1 chunk +76 lines, -0 lines 0 comments Download
A testing/android/junit/java/src/org/chromium/testing/local/GtestFilter.java View 1 chunk +95 lines, -0 lines 0 comments Download
A testing/android/junit/java/src/org/chromium/testing/local/GtestListener.java View 1 chunk +80 lines, -0 lines 0 comments Download
A testing/android/junit/java/src/org/chromium/testing/local/GtestLogger.java View 1 chunk +109 lines, -0 lines 0 comments Download
A testing/android/junit/java/src/org/chromium/testing/local/JunitTestArgParser.java View 1 chunk +90 lines, -0 lines 0 comments Download
A testing/android/junit/java/src/org/chromium/testing/local/JunitTestMain.java View 1 chunk +96 lines, -0 lines 0 comments Download
A testing/android/junit/java/src/org/chromium/testing/local/PackageFilter.java View 1 chunk +41 lines, -0 lines 0 comments Download
A testing/android/junit/java/src/org/chromium/testing/local/RunnerFilter.java View 1 chunk +45 lines, -0 lines 0 comments Download
A testing/android/junit/javatests/src/org/chromium/testing/local/GtestFilterTest.java View 1 chunk +118 lines, -0 lines 0 comments Download
A testing/android/junit/javatests/src/org/chromium/testing/local/GtestLoggerTest.java View 1 chunk +144 lines, -0 lines 0 comments Download
A testing/android/junit/javatests/src/org/chromium/testing/local/PackageFilterTest.java View 1 chunk +47 lines, -0 lines 0 comments Download
A testing/android/junit/javatests/src/org/chromium/testing/local/RunnerFilterTest.java View 1 chunk +56 lines, -0 lines 0 comments Download
A testing/android/junit/junit_test.gyp View 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/junit/junit.gyp View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
phoglund_chromium
Created Revert of Revert of [Android] JUnit runner + gyp changes.
6 years, 2 months ago (2014-09-24 14:01:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596303002/1
6 years, 2 months ago (2014-09-24 14:01:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 71c3818e8c970212c4ce90152ca302b7451c0e12
6 years, 2 months ago (2014-09-24 14:02:07 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-09-24 14:02:45 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e9dc50aecf078d7826fe8e4611b2c238aab3f23
Cr-Commit-Position: refs/heads/master@{#296406}

Powered by Google App Engine
This is Rietveld 408576698