chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc - Issue 596253003: DevTools: RemoteDevice and RemoteBrowser are now value types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc

Issue 596253003: DevTools: RemoteDevice and RemoteBrowser are now value types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pfc3

Patch Set: Fixed test Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc

diff --git a/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc b/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc

index b6e2ec09901de0838200a1144c521d2ac706b0ef..a9d8fb99c7876c256d39e671f7b88adc26057852 100644

--- a/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc

+++ b/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc

@@ -94,11 +94,11 @@ class AdbClientSocketTest : public InProcessBrowserTest,

ASSERT_EQ("4.0", webview->version());

std::vector<DevToolsAndroidBridge::RemotePage*> chrome_pages =

- chrome->CreatePages();

+ android_bridge_->CreatePages(chrome);

std::vector<DevToolsAndroidBridge::RemotePage*> chrome_beta_pages =

- chrome_beta->CreatePages();

+ android_bridge_->CreatePages(chrome_beta);

std::vector<DevToolsAndroidBridge::RemotePage*> webview_pages =

- webview->CreatePages();

+ android_bridge_->CreatePages(webview);

ASSERT_EQ(1U, chrome_pages.size());

ASSERT_EQ(0U, chrome_beta_pages.size());

« no previous file with comments | « no previous file | chrome/browser/devtools/device/devtools_android_bridge.h » ('j') | chrome/browser/devtools/device/devtools_android_bridge.h » ('J')