chrome/browser/ui/webui/devtools_ui.cc - Issue 596253003: DevTools: RemoteDevice and RemoteBrowser are now value types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/devtools_ui.cc

Issue 596253003: DevTools: RemoteDevice and RemoteBrowser are now value types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pfc3

Patch Set: Rebased Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/devtools_ui.cc

diff --git a/chrome/browser/ui/webui/devtools_ui.cc b/chrome/browser/ui/webui/devtools_ui.cc

index 94945c1d14443b780022639d4d28d7a60b56ee67..6f40ca92f8b3c4ad9b156e3ce53ef83df98de168 100644

--- a/chrome/browser/ui/webui/devtools_ui.cc

+++ b/chrome/browser/ui/webui/devtools_ui.cc

@@ -321,8 +321,11 @@ bool OpenRemotePageRequest::OpenInBrowser(

if (browser->serial() == kLocalSerial)

return false;

#endif // defined(DEBUG_DEVTOOLS)

- browser->Open(url_, base::Bind(&OpenRemotePageRequest::RemotePageOpened,

- base::Unretained(this)));

+ android_bridge_->OpenRemotePage(

+ browser,

+ url_,

+ base::Bind(&OpenRemotePageRequest::RemotePageOpened,

+ base::Unretained(this)));

return true;

}

« no previous file with comments | « chrome/browser/devtools/devtools_targets_ui.cc ('k') | no next file » | no next file with comments »