Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Side by Side Diff: chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc

Issue 596253003: DevTools: RemoteDevice and RemoteBrowser are now value types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pfc3
Patch Set: Rebased Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/devtools/device/devtools_android_bridge.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/devtools/device/adb/adb_device_provider.h" 5 #include "chrome/browser/devtools/device/adb/adb_device_provider.h"
6 #include "chrome/browser/devtools/device/adb/mock_adb_server.h" 6 #include "chrome/browser/devtools/device/adb/mock_adb_server.h"
7 #include "chrome/browser/devtools/device/devtools_android_bridge.h" 7 #include "chrome/browser/devtools/device/devtools_android_bridge.h"
8 #include "chrome/browser/devtools/devtools_target_impl.h" 8 #include "chrome/browser/devtools/devtools_target_impl.h"
9 #include "chrome/browser/ui/browser.h" 9 #include "chrome/browser/ui/browser.h"
10 #include "chrome/test/base/in_process_browser_test.h" 10 #include "chrome/test/base/in_process_browser_test.h"
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 87
88 scoped_refptr<DevToolsAndroidBridge::RemoteBrowser> noprocess = 88 scoped_refptr<DevToolsAndroidBridge::RemoteBrowser> noprocess =
89 FindBrowserByDisplayName(browsers, "Noprocess"); 89 FindBrowserByDisplayName(browsers, "Noprocess");
90 ASSERT_TRUE(noprocess.get()); 90 ASSERT_TRUE(noprocess.get());
91 91
92 ASSERT_EQ("32.0.1679.0", chrome->version()); 92 ASSERT_EQ("32.0.1679.0", chrome->version());
93 ASSERT_EQ("31.0.1599.0", chrome_beta->version()); 93 ASSERT_EQ("31.0.1599.0", chrome_beta->version());
94 ASSERT_EQ("4.0", webview->version()); 94 ASSERT_EQ("4.0", webview->version());
95 95
96 std::vector<DevToolsAndroidBridge::RemotePage*> chrome_pages = 96 std::vector<DevToolsAndroidBridge::RemotePage*> chrome_pages =
97 chrome->CreatePages(); 97 android_bridge_->CreatePages(chrome);
98 std::vector<DevToolsAndroidBridge::RemotePage*> chrome_beta_pages = 98 std::vector<DevToolsAndroidBridge::RemotePage*> chrome_beta_pages =
99 chrome_beta->CreatePages(); 99 android_bridge_->CreatePages(chrome_beta);
100 std::vector<DevToolsAndroidBridge::RemotePage*> webview_pages = 100 std::vector<DevToolsAndroidBridge::RemotePage*> webview_pages =
101 webview->CreatePages(); 101 android_bridge_->CreatePages(webview);
102 102
103 ASSERT_EQ(1U, chrome_pages.size()); 103 ASSERT_EQ(1U, chrome_pages.size());
104 ASSERT_EQ(1U, chrome_beta_pages.size()); 104 ASSERT_EQ(1U, chrome_beta_pages.size());
105 ASSERT_EQ(2U, webview_pages.size()); 105 ASSERT_EQ(2U, webview_pages.size());
106 106
107 // Check that we have non-empty description for webview pages. 107 // Check that we have non-empty description for webview pages.
108 ASSERT_EQ(0U, chrome_pages[0]->GetTarget()->GetDescription().size()); 108 ASSERT_EQ(0U, chrome_pages[0]->GetTarget()->GetDescription().size());
109 ASSERT_EQ(0U, chrome_beta_pages[0]->GetTarget()->GetDescription().size()); 109 ASSERT_EQ(0U, chrome_beta_pages[0]->GetTarget()->GetDescription().size());
110 ASSERT_NE(0U, webview_pages[0]->GetTarget()->GetDescription().size()); 110 ASSERT_NE(0U, webview_pages[0]->GetTarget()->GetDescription().size());
111 ASSERT_NE(0U, webview_pages[1]->GetTarget()->GetDescription().size()); 111 ASSERT_NE(0U, webview_pages[1]->GetTarget()->GetDescription().size());
(...skipping 12 matching lines...) Expand all
124 scoped_refptr<DevToolsAndroidBridge> android_bridge_; 124 scoped_refptr<DevToolsAndroidBridge> android_bridge_;
125 DevToolsAndroidBridge::RemoteDevices devices_; 125 DevToolsAndroidBridge::RemoteDevices devices_;
126 }; 126 };
127 127
128 IN_PROC_BROWSER_TEST_F(AdbClientSocketTest, TestAdbClientSocket) { 128 IN_PROC_BROWSER_TEST_F(AdbClientSocketTest, TestAdbClientSocket) {
129 StartMockAdbServer(); 129 StartMockAdbServer();
130 StartTest(); 130 StartTest();
131 CheckDevices(); 131 CheckDevices();
132 StopMockAdbServer(); 132 StopMockAdbServer();
133 } 133 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/devtools/device/devtools_android_bridge.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698