Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 596253002: Don't use setFixedLayoutSize in WebViewPlugin. (Closed)

Created:
6 years, 3 months ago by mkosiba (inactive)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, Bernhard Bauer, bokan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't use setFixedLayoutSize in WebViewPlugin. The original usage of the method was added to fix a rendering issue with the YouTube plugin: see http://crrev.com/2862031 . Setting an appropriate viewport seems to work as well and removes usage of a method I'm trying to remove. BUG=417221 Committed: https://crrev.com/3774498717e6c0c717d132ff1e866adf57a7f968 Cr-Commit-Position: refs/heads/master@{#296440}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/renderer/resources/blocked_plugin.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/resources/click_to_play_plugin.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/resources/disabled_plugin.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/resources/mobile_youtube_plugin.html View 1 chunk +1 line, -0 lines 0 comments Download
M components/plugins/renderer/webview_plugin.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
mkosiba (inactive)
PTAL
6 years, 3 months ago (2014-09-24 11:22:48 UTC) #2
Bernhard Bauer
lgtm
6 years, 3 months ago (2014-09-24 11:24:07 UTC) #4
mkosiba (inactive)
didn't notice Jochen is (slow for reviews) + James for stamp in case Jochen doesn't ...
6 years, 3 months ago (2014-09-24 11:31:36 UTC) #6
James Hawkins
lgtm
6 years, 2 months ago (2014-09-24 16:32:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596253002/1
6 years, 2 months ago (2014-09-24 16:40:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as e10b1475a16b7f417333738964533d49db1474b7
6 years, 2 months ago (2014-09-24 16:45:08 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-09-24 16:45:55 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3774498717e6c0c717d132ff1e866adf57a7f968
Cr-Commit-Position: refs/heads/master@{#296440}

Powered by Google App Engine
This is Rietveld 408576698