Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 596233003: Move ensure keyboard mic check in MediaStreamManager to SetupRequest. (Closed)

Created:
6 years, 3 months ago by Henrik Grunell
Modified:
6 years, 3 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@kmic_test
Project:
chromium
Visibility:
Public.

Description

Move ensure keyboard mic check in MediaStreamManager to SetupRequest. Since we on ChromeOS don't (always) need to enumerate devices at all. BUG=345296 NOTRY=true Committed: https://crrev.com/c496fa8a31f5ad0d2242c3f64aaad729d3d0704e Cr-Commit-Position: refs/heads/master@{#296420}

Patch Set 1 #

Patch Set 2 : Use the proper base file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -10 lines) Patch
M content/browser/renderer_host/media/media_stream_manager.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 1 3 chunks +15 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Henrik Grunell
6 years, 3 months ago (2014-09-24 12:06:58 UTC) #2
no longer working on chromium
On 2014/09/24 12:06:58, Henrik Grunell wrote: lgtm
6 years, 3 months ago (2014-09-24 13:05:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596233003/20001
6 years, 3 months ago (2014-09-24 13:08:53 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-24 15:09:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596233003/20001
6 years, 3 months ago (2014-09-24 15:37:28 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 02002147fc3242195863102a018ea473b137b24c
6 years, 3 months ago (2014-09-24 15:37:53 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 15:38:50 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/c496fa8a31f5ad0d2242c3f64aaad729d3d0704e
Cr-Commit-Position: refs/heads/master@{#296420}

Powered by Google App Engine
This is Rietveld 408576698