Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 59623015: GTTF: Flip test launcher defaults (developer mode is now default) (Closed)

Created:
7 years, 1 month ago by Paweł Hajdan Jr.
Modified:
7 years ago
Reviewers:
sky, M-A Ruel
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, jam
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : trybots #

Patch Set 4 : trybots #

Patch Set 5 : trybots #

Patch Set 6 : rebase #

Patch Set 7 : env variable #

Patch Set 8 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -50 lines) Patch
M base/test/launcher/test_launcher.h View 1 chunk +3 lines, -0 lines 0 comments Download
M base/test/launcher/test_launcher.cc View 1 2 3 4 5 6 8 chunks +53 lines, -17 lines 0 comments Download
M base/test/launcher/unit_test_launcher.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M base/test/test_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M base/test/test_switches.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser_tests.isolate View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/interactive_ui_tests.isolate View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/sync_integration_tests.isolate View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M content/content_browsertests.isolate View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M content/public/test/test_launcher.cc View 1 2 2 chunks +2 lines, -21 lines 0 comments Download
M third_party/cacheinvalidation/cacheinvalidation_unittests.isolate View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Paweł Hajdan Jr.
7 years, 1 month ago (2013-11-14 02:53:24 UTC) #1
sky
LGTM
7 years, 1 month ago (2013-11-14 15:39:42 UTC) #2
Paweł Hajdan Jr.
+M-A for .isolate file changes
7 years, 1 month ago (2013-11-15 00:11:35 UTC) #3
M-A Ruel
.isolate files lgtm
7 years, 1 month ago (2013-11-15 00:12:33 UTC) #4
Paweł Hajdan Jr.
Scott, could you take another look at the test_launcher.cc changes? It turns out that some ...
7 years ago (2013-11-26 19:57:47 UTC) #5
Paweł Hajdan Jr.
On 2013/11/26 19:57:47, Paweł Hajdan Jr. wrote: > Scott, could you take another look at ...
7 years ago (2013-11-27 00:25:38 UTC) #6
Paweł Hajdan Jr.
Committed patchset #8 manually as r237448.
7 years ago (2013-11-27 00:26:01 UTC) #7
sky
7 years ago (2013-12-02 15:22:30 UTC) #8
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698