Issue 59623009: Make HForceRepresentation an idef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 59623009: Make HForceRepresentation an idef. (Closed)

Created:
7 years, 1 month ago by mvstanton

Modified:
7 years, 1 month ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make HForceRepresentation an idef. An optimization in the array constructor wasn't firing because the code would check for constant values, failing to find them through intervening HForceRepresentation instructions. Repaired this site. A follow-on CL will provide a better way of making decisions based on constant HValues. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17708

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	src/hydrogen.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
	M	src/hydrogen-instructions.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mvstanton

7 years, 1 month ago (2013-11-13 17:03:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r17708 (presubmit successful).

Expand Messages | Collapse Messages