Issue 59623008: Let the TextTrackCue constructor return a VTTCue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 59623008: Let the TextTrackCue constructor return a VTTCue (Closed)

Created:
7 years, 1 month ago by philipj_slow

Modified:
7 years, 1 month ago

Reviewers:
adamk, eseidel

CC:
blink-reviews, Nils Barth (inactive), nessy, arv+blink, jsbell+bindings_chromium.org, marja+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, kojih, haraken, Nate Chapin, vcarbune.chromium, Inactive, gasubic

Base URL:
https://chromium.googlesource.com/chromium/blink.git@vttcue

Visibility:
Public.

More Reviews

Description

Let the TextTrackCue constructor return a VTTCue This is for legacy compat and hopefully short lived. UseCounter::TextTrackCueConstructor is brought back to help determine when this can be reverted. Note that any previously collected usage data from this counter is useless, because it accidentally counted all TextTrackCue creation, not only the script-exposed constructor. BUG=270340

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -1 line)			Patch
M	LayoutTests/fast/js/constructor-length.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/fast/js/constructor-length-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	LayoutTests/media/track/text-track-cue-constructor.html	View	1 chunk	+23 lines, -0 lines	0 comments	Download
A	LayoutTests/media/track/text-track-cue-constructor-expected.txt	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	Source/bindings/v8/custom/V8TextTrackCueCustom.cpp	View	1 chunk	+19 lines, -0 lines	0 comments	Download
M	Source/core/html/track/TextTrackCue.idl	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

philipj_slow

7 years, 1 month ago (2013-11-14 08:54:14 UTC) #2

Closing in favor of https://codereview.chromium.org/72543003/

Expand Messages | Collapse Messages