Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Issue 59623007: roll gyp 1773:1779 (Closed)

Created:
7 years, 1 month ago by Nico
Modified:
7 years, 1 month ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, justincohen
Visibility:
Public.

Description

roll gyp 1773:1779 1774: xcode: Adds generator support for Xcode 5 xctest targets. 1775: xcode & ninja/mac: Use xcrun instead of DEVELOPER_BIN_DIR. 1776: win: Add Visual Studio 2013 to the autodetect list 1777: ninja/win: Add support for 'resource_include_dirs' 1778: ninja/ios: Add storyboard support. 1779: ninja/mac: Let mac_bundle_resources keep file permissions. BUG=315383 R=mark@chromium.org TBR=mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233211

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
7 years, 1 month ago (2013-11-06 03:36:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/59623007/1
7 years, 1 month ago (2013-11-06 03:57:01 UTC) #2
Mark Mentovai
LGTM
7 years, 1 month ago (2013-11-06 04:08:31 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-06 04:44:55 UTC) #4
Nico
7 years, 1 month ago (2013-11-06 05:13:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r233211 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698