Issue 59623005: app_list: Fix sync animation crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 59623005: app_list: Fix sync animation crash. (Closed)

Created:
7 years, 1 month ago by xiyuan

Modified:
7 years, 1 month ago

Reviewers:
jennyz

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

app_list: Fix sync animation crash. AppsGridView is used for folder view and it has a NULL item_list_ initially. This causes a crash when attempting to create pulsing blocks for sync animation. BUG=314855 R=jennyz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233226

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	ui/app_list/views/apps_grid_view.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/59623005/1

7 years, 1 month ago (2013-11-05 22:22:13 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=220172

7 years, 1 month ago (2013-11-06 02:59:09 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/59623005/1

7 years, 1 month ago (2013-11-06 03:28:13 UTC) #5

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 1 month ago (2013-11-06 04:44:48 UTC) #6

xiyuan

7 years, 1 month ago (2013-11-06 06:01:02 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 manually as r233226 (presubmit successful).

Expand Messages | Collapse Messages