Check multi-crx path for force update based on manifest entries

Check multi-crx path for force update based on manifest entries

The previous CL (https://codereview.chromium.org/540673002) was not fully
correct.  It used a path based on <nacl_arch>, but the path can be arbitrary
based on entries in the extension's manifest.

If the extension used non-nacl_arch paths, it would continually download and
install the same copy of the extension, eventually filling up the user's disk if
left long enough without restarting Chrome.

BUG=414156
Committed: https://crrev.com/74cafd39701dd9b66ea219a2a4ef0c9d88d76eec
Cr-Commit-Position: refs/heads/master@{#296514}

[elijahtaylor1, 2014-09-24 04:39:07]

elijahtaylor@chromium.org changed reviewers:
+ rockot@chromium.org

[elijahtaylor1, 2014-09-24 04:40:28]

Hi Ken, PTAL, quickly if possible.  I think we need to merge this CL to M38, to
fully fix crbug.com/409948

[Ken Rockot(use gerrit already), 2014-09-24 16:14:15]

lgtm - thanks for doing this.

I regret that I clearly just guessed about how those arch names translated to
paths. :/

https://codereview.chromium.org/596193002/diff/1/chrome/browser/extensions/up...
File chrome/browser/extensions/updater/extension_updater.cc (right):

https://codereview.chromium.org/596193002/diff/1/chrome/browser/extensions/up...
chrome/browser/extensions/updater/extension_updater.cc:137:
extension->path().Append(subpath);
You want AppendASCII here

[elijahtaylor1, 2014-09-24 16:35:48]

No worries.  I think what you did works for all apps that use the stock NaCl
create_nmf tool to stage files, which is probably most apps.  ARC has a custom
script that pulls everything together for packaging, which is why we see this.

The good news is that it looks like the ChromeOS extension cache might have
saved us here so we don't fill up disk space on chromebooks, just desktop chrome
:)

https://codereview.chromium.org/596193002/diff/1/chrome/browser/extensions/up...
File chrome/browser/extensions/updater/extension_updater.cc (right):

https://codereview.chromium.org/596193002/diff/1/chrome/browser/extensions/up...
chrome/browser/extensions/updater/extension_updater.cc:137:
extension->path().Append(subpath);
On 2014/09/24 16:14:15, Ken Rockot (slow this week) wrote:
> You want AppendASCII here

Done.

[elijahtaylor1, 2014-09-24 20:32:36]

The CQ bit was checked by elijahtaylor@chromium.org

[commit-bot: I haz the power, 2014-09-24 20:33:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/596193002/20001

[commit-bot: I haz the power, 2014-09-24 20:57:50]

Committed patchset #2 (id:20001) as 1d32919cf61431cb2adf1d1ebeecb2445f464ad4

[commit-bot: I haz the power, 2014-09-24 20:58:16]

Patchset 2 (id:??) landed as
https://crrev.com/74cafd39701dd9b66ea219a2a4ef0c9d88d76eec
Cr-Commit-Position: refs/heads/master@{#296514}