Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 596163002: Revert "Adds UMA to measure when the data reduction proxy via header is missing" (Closed)

Created:
6 years, 3 months ago by scottmg
Modified:
6 years, 3 months ago
Reviewers:
jiayl
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "Adds UMA to measure when the data reduction proxy via header is missing" This reverts commit ba1e1e3f7ea6edae987e6cfa92086807bf74260b. <jiayl_> It broken component_unittests: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20(1)/builds/49443/steps/components_unittests/logs/RecordMissingViaHeaderBytes BUG= TBR=jiayl@chromium.org Committed: https://crrev.com/c1e1fe3e72078b75028cf5ea06ffa318e0cfcd49 Cr-Commit-Position: refs/heads/master@{#296317}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -431 lines) Patch
M chrome/browser/net/chrome_network_delegate.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/data_reduction_proxy.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/browser/data_reduction_proxy_protocol.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M components/data_reduction_proxy/browser/data_reduction_proxy_protocol_unittest.cc View 2 chunks +12 lines, -1 line 0 comments Download
M components/data_reduction_proxy/browser/data_reduction_proxy_settings_test_utils.cc View 2 chunks +8 lines, -1 line 0 comments Download
M components/data_reduction_proxy/browser/data_reduction_proxy_tamper_detection_unittest.cc View 2 chunks +6 lines, -1 line 0 comments Download
M components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.h View 5 chunks +6 lines, -31 lines 0 comments Download
M components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.cc View 8 chunks +8 lines, -64 lines 0 comments Download
M components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats_unittest.cc View 5 chunks +0 lines, -252 lines 0 comments Download
D components/data_reduction_proxy/common/data_reduction_proxy_headers_test_utils.h View 1 chunk +0 lines, -17 lines 0 comments Download
D components/data_reduction_proxy/common/data_reduction_proxy_headers_test_utils.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M components/data_reduction_proxy/common/data_reduction_proxy_headers_unittest.cc View 1 chunk +12 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +0 lines, -35 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
scottmg
Committed patchset #1 (id:1) manually as c1e1fe3 (presubmit successful).
6 years, 3 months ago (2014-09-24 00:39:07 UTC) #2
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 00:39:07 UTC) #3
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c1e1fe3e72078b75028cf5ea06ffa318e0cfcd49
Cr-Commit-Position: refs/heads/master@{#296317}

Powered by Google App Engine
This is Rietveld 408576698