Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 596133002: [NaCl SDK] nacl_io: use standard __BEGIN/__END_DECLS in poll.h (Closed)

Created:
6 years, 3 months ago by Sam Clegg
Modified:
6 years, 3 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] nacl_io: use standard __BEGIN/__END_DECLS in poll.h In case this header is included without sdk_util headers being available (as can happen in naclports). Committed: https://crrev.com/f5bace135f1ff2fa3a68bc3262e55f6b9e71db53 Cr-Commit-Position: refs/heads/master@{#296525}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M native_client_sdk/src/libraries/nacl_io/include/sys/poll.h View 1 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Sam Clegg
I'm sure I've send this CL out before but I can't find it in my ...
6 years, 3 months ago (2014-09-23 23:25:09 UTC) #2
binji
https://codereview.chromium.org/596133002/diff/1/native_client_sdk/src/libraries/nacl_io/include/sys/poll.h File native_client_sdk/src/libraries/nacl_io/include/sys/poll.h (right): https://codereview.chromium.org/596133002/diff/1/native_client_sdk/src/libraries/nacl_io/include/sys/poll.h#newcode31 native_client_sdk/src/libraries/nacl_io/include/sys/poll.h:31: __END_DECLS backward?
6 years, 3 months ago (2014-09-23 23:27:08 UTC) #3
binji
lgtm
6 years, 3 months ago (2014-09-24 00:25:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596133002/20001
6 years, 3 months ago (2014-09-24 00:28:56 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/17839) ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/builds/17772)
6 years, 3 months ago (2014-09-24 00:34:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596133002/20001
6 years, 3 months ago (2014-09-24 21:18:25 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 6865357c48cb21fb7e73cdcf1533c3bbc42f4e42
6 years, 3 months ago (2014-09-24 21:30:16 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 21:31:01 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f5bace135f1ff2fa3a68bc3262e55f6b9e71db53
Cr-Commit-Position: refs/heads/master@{#296525}

Powered by Google App Engine
This is Rietveld 408576698