Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6210)

Unified Diff: chrome/browser/ui/views/certificate_viewer_win.cc

Issue 59613009: fix second window not painting on aura while cert dialog is open (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comment Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/certificate_viewer_win.cc
diff --git a/chrome/browser/ui/views/certificate_viewer_win.cc b/chrome/browser/ui/views/certificate_viewer_win.cc
index fa345391d1eb89c4dec3a0a3ba4532f566aa4c20..4c4fd8f5617b69992184b3d020e05a248f6ae409 100644
--- a/chrome/browser/ui/views/certificate_viewer_win.cc
+++ b/chrome/browser/ui/views/certificate_viewer_win.cc
@@ -9,6 +9,7 @@
#pragma comment(lib, "cryptui.lib")
#include "base/logging.h"
+#include "base/message_loop/message_loop.h"
#include "net/cert/x509_certificate.h"
#if defined(USE_AURA)
@@ -40,6 +41,11 @@ void ShowCertificateViewerImpl(content::WebContents* web_contents,
view_info.rghStores = &cert_store;
BOOL properties_changed;
+ // We must allow nested tasks to dispatch so that, e.g. gpu tasks are
+ // processed for painting. This allows a second window to continue painting
+ // while the the certificate dialog is open.
+ base::MessageLoop::ScopedNestableTaskAllower allow(
+ base::MessageLoop::current());
// This next call blocks but keeps processing windows messages, making it
// modal to the browser window.
BOOL rv = ::CryptUIDlgViewCertificate(&view_info, &properties_changed);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698