runtime/vm/object_mips_test.cc - Issue 59613005: Merge (x & y) == 0 pattern to emit a single test instruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object_mips_test.cc

Issue 59613005: Merge (x & y) == 0 pattern to emit a single test instruction. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/object_mips_test.cc

===================================================================

--- runtime/vm/object_mips_test.cc (revision 29964)

+++ runtime/vm/object_mips_test.cc (working copy)

@@ -19,13 +19,13 @@

// This is used to test Code and Instruction object creation.

void GenerateIncrement(Assembler* assembler) {

__ Push(ZR);

- __ lw(TMP1, Address(SP, 0));

- __ addiu(TMP1, TMP1, Immediate(1));

- __ sw(TMP1, Address(SP, 0));

- __ lw(TMP1, Address(SP, 0));

- __ addiu(TMP1, TMP1, Immediate(1));

+ __ lw(TMP, Address(SP, 0));

+ __ addiu(TMP, TMP, Immediate(1));

+ __ sw(TMP, Address(SP, 0));

+ __ lw(TMP, Address(SP, 0));

+ __ addiu(TMP, TMP, Immediate(1));

__ Pop(V0);

- __ mov(V0, TMP1);

+ __ mov(V0, TMP);

__ Ret();

}

« runtime/vm/intermediate_language_ia32.cc ('K') | « runtime/vm/intrinsifier_mips.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »