Merge (x & y) == 0 pattern to emit a single test instruction.

runtime/vm/intrinsifier_mips.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_MIPS.
 #if defined(TARGET_ARCH_MIPS)
 
 #include "vm/intrinsifier.h"
 
 #include "vm/assembler.h"
@@ skipping 13 matching lines @@
   const intptr_t kTypeArgumentsOffset = 1 * kWordSize;
   const intptr_t kArrayLengthOffset = 0 * kWordSize;
   Label fall_through;
 
   // Compute the size to be allocated, it is based on the array length
   // and is computed as:
   // RoundedAllocationSize((array_length * kwordSize) + sizeof(RawArray)).
   __ lw(T3, Address(SP, kArrayLengthOffset));  // Array length.
 
   // Check that length is a positive Smi.
-  __ andi(CMPRES, T3, Immediate(kSmiTagMask));
-  __ bne(CMPRES, ZR, &fall_through);
+  __ andi(CMPRES1, T3, Immediate(kSmiTagMask));
+  __ bne(CMPRES1, ZR, &fall_through);
   __ bltz(T3, &fall_through);
 
   // Check for maximum allowed length.
   const intptr_t max_len =
       reinterpret_cast<int32_t>(Smi::New(Array::kMaxElements));
   __ BranchUnsignedGreater(T3, max_len, &fall_through);
 
   const intptr_t fixed_size = sizeof(RawArray) + kObjectAlignment - 1;
   __ LoadImmediate(T2, fixed_size);
   __ sll(T3, T3, 1);  // T3 is  a Smi.
   __ addu(T2, T2, T3);
   ASSERT(kSmiTagShift == 1);
   __ LoadImmediate(T3, ~(kObjectAlignment - 1));
   __ and_(T2, T2, T3);
 
   // T2: Allocation size.
 
   Isolate* isolate = Isolate::Current();
   Heap* heap = isolate->heap();
 
   __ LoadImmediate(T3, heap->TopAddress());
   __ lw(T0, Address(T3, 0));  // Potential new object start.
 
-  __ AdduDetectOverflow(T1, T0, T2, CMPRES);  // Potential next object start.
-  __ bltz(CMPRES, &fall_through);  // CMPRES < 0 on overflow.
+  __ AdduDetectOverflow(T1, T0, T2, CMPRES1);  // Potential next object start.
+  __ bltz(CMPRES1, &fall_through);  // CMPRES1 < 0 on overflow.
 
   // Check if the allocation fits into the remaining space.
   // T0: potential new object start.
   // T1: potential next object start.
   // T2: allocation size.
   __ LoadImmediate(T4, heap->TopAddress());
   __ lw(T4, Address(T4, 0));
   __ BranchUnsignedGreaterEqual(T1, T4, &fall_through);
 
   // Successfully allocated the object(s), now update top to point to
@@ skipping 12 matching lines @@
 
     __ BranchUnsignedGreater(T2, RawObject::SizeTag::kMaxSizeTag, &overflow);
     __ b(&done);
     __ delay_slot()->sll(T2, T2, shift);
     __ Bind(&overflow);
     __ mov(T2, ZR);
     __ Bind(&done);
 
     // Get the class index and insert it into the tags.
     // T2: size and bit tags.
-    __ LoadImmediate(TMP1, RawObject::ClassIdTag::encode(cls.id()));
-    __ or_(T2, T2, TMP1);
+    __ LoadImmediate(TMP, RawObject::ClassIdTag::encode(cls.id()));
+    __ or_(T2, T2, TMP);
     __ sw(T2, FieldAddress(T0, Array::tags_offset()));  // Store tags.
   }
 
   // T0: new object start as a tagged pointer.
   // T1: new object end address.
   // Store the type argument field.
   __ lw(T2, Address(SP, kTypeArgumentsOffset));  // Type argument.
   __ StoreIntoObjectNoBarrier(T0,
                               FieldAddress(T0, Array::type_arguments_offset()),
                               T2);
@@ skipping 38 matching lines @@
 void Intrinsifier::ImmutableList_getLength(Assembler* assembler) {
   return Array_getLength(assembler);
 }
 
 
 void Intrinsifier::Array_getIndexed(Assembler* assembler) {
   Label fall_through;
 
   __ lw(T0, Address(SP, + 0 * kWordSize));  // Index
 
-  __ andi(CMPRES, T0, Immediate(kSmiTagMask));
-  __ bne(CMPRES, ZR, &fall_through);  // Index is not an smi, fall through
+  __ andi(CMPRES1, T0, Immediate(kSmiTagMask));
+  __ bne(CMPRES1, ZR, &fall_through);  // Index is not an smi, fall through
   __ delay_slot()->lw(T1, Address(SP, + 1 * kWordSize));  // Array
 
   // range check
   __ lw(T2, FieldAddress(T1, Array::length_offset()));
   __ BranchUnsignedGreaterEqual(T0, T2, &fall_through);
 
   ASSERT(kSmiTagShift == 1);
   // array element at T1 + T0*2 + Array::data_offset - 1
   __ sll(T2, T0, 1);
   __ addu(T2, T1, T2);
@@ skipping 45 matching lines @@
     // Check if it's dynamic.
     // For now handle only TypeArguments and bail out if InstantiatedTypeArgs.
     __ LoadClassId(CMPRES1, T1);
     __ BranchNotEqual(CMPRES1, kTypeArgumentsCid, &fall_through);
 
     // Get type at index 0.
     __ lw(T0, FieldAddress(T1, TypeArguments::type_at_offset(0)));
     __ BranchEqual(T0, Type::ZoneHandle(Type::DynamicType()), &checked_ok);
 
     // Check for int and num.
-    __ andi(CMPRES, T2, Immediate(kSmiTagMask));
-    __ bne(CMPRES, ZR, &fall_through);  // Non-smi value.
+    __ andi(CMPRES1, T2, Immediate(kSmiTagMask));
+    __ bne(CMPRES1, ZR, &fall_through);  // Non-smi value.
 
     __ BranchEqual(T0, Type::ZoneHandle(Type::IntType()), &checked_ok);
     __ BranchNotEqual(T0, Type::ZoneHandle(Type::Number()), &fall_through);
     __ Bind(&checked_ok);
   }
   __ lw(T1, Address(SP, 1 * kWordSize));  // Index.
-  __ andi(CMPRES, T1, Immediate(kSmiTagMask));
+  __ andi(CMPRES1, T1, Immediate(kSmiTagMask));
   // Index not Smi.
-  __ bne(CMPRES, ZR, &fall_through);
+  __ bne(CMPRES1, ZR, &fall_through);
 
   __ lw(T0, Address(SP, 2 * kWordSize));  // Array.
   // Range check.
   __ lw(T3, FieldAddress(T0, Array::length_offset()));  // Array length.
   // Runtime throws exception.
   __ BranchUnsignedGreaterEqual(T1, T3, &fall_through);
 
   // Note that T1 is Smi, i.e, times 2.
   ASSERT(kSmiTagShift == 1);
   __ lw(T2, Address(SP, 0 * kWordSize));  // Value.
@@ skipping 89 matching lines @@
   __ Ret();
   __ delay_slot()->lw(V0, FieldAddress(V0, Array::length_offset()));
 }
 
 
 void Intrinsifier::GrowableList_getIndexed(Assembler* assembler) {
   Label fall_through;
 
   __ lw(T0, Address(SP, 0 * kWordSize));  // Index
 
-  __ andi(CMPRES, T0, Immediate(kSmiTagMask));
-  __ bne(CMPRES, ZR, &fall_through);  // Index is not an smi, fall through
+  __ andi(CMPRES1, T0, Immediate(kSmiTagMask));
+  __ bne(CMPRES1, ZR, &fall_through);  // Index is not an smi, fall through
   __ delay_slot()->lw(T1, Address(SP, 1 * kWordSize));  // Array
 
   // range check
   __ lw(T2, FieldAddress(T1, GrowableObjectArray::length_offset()));
   __ BranchUnsignedGreaterEqual(T0, T2, &fall_through);
 
   __ lw(T2, FieldAddress(T1, GrowableObjectArray::data_offset()));  // data
 
   ASSERT(kSmiTagShift == 1);
   // array element at T2 + T0 * 2 + Array::data_offset - 1
   __ sll(T3, T0, 1);
   __ addu(T2, T2, T3);
   __ Ret();
   __ delay_slot()->lw(V0, FieldAddress(T2, Array::data_offset()));
   __ Bind(&fall_through);
 }
 
 
 // Set value into growable object array at specified index.
 // On stack: growable array (+2), index (+1), value (+0).
 void Intrinsifier::GrowableList_setIndexed(Assembler* assembler) {
   if (FLAG_enable_type_checks) {
     return;
   }
   Label fall_through;
   __ lw(T1, Address(SP, 1 * kWordSize));  // Index.
-  __ andi(CMPRES, T1, Immediate(kSmiTagMask));
-  __ bne(CMPRES, ZR, &fall_through);  // Non-smi index.
+  __ andi(CMPRES1, T1, Immediate(kSmiTagMask));
+  __ bne(CMPRES1, ZR, &fall_through);  // Non-smi index.
   __ delay_slot()->lw(T0, Address(SP, 2 * kWordSize));  // GrowableArray.
   // Range check using _length field.
   __ lw(T2, FieldAddress(T0, GrowableObjectArray::length_offset()));
   // Runtime throws exception.
   __ BranchUnsignedGreaterEqual(T1, T2, &fall_through);
   __ lw(T0, FieldAddress(T0, GrowableObjectArray::data_offset()));  // data.
   __ lw(T2, Address(SP, 0 * kWordSize));  // Value.
   // Note that T1 is Smi, i.e, times 2.
   ASSERT(kSmiTagShift == 1);
   __ sll(T1, T1, 1);
   __ addu(T1, T0, T1);
   __ StoreIntoObject(T0,
                      FieldAddress(T1, Array::data_offset()),
                      T2);
   __ Ret();
   __ Bind(&fall_through);
 }
 
 
 // Set length of growable object array. The length cannot
 // be greater than the length of the data container.
 // On stack: growable array (+1), length (+0).
 void Intrinsifier::GrowableList_setLength(Assembler* assembler) {
   Label fall_through;
   __ lw(T1, Address(SP, 0 * kWordSize));  // Length value.
-  __ andi(CMPRES, T1, Immediate(kSmiTagMask));
-  __ bne(CMPRES, ZR, &fall_through);  // Non-smi length.
+  __ andi(CMPRES1, T1, Immediate(kSmiTagMask));
+  __ bne(CMPRES1, ZR, &fall_through);  // Non-smi length.
   __ delay_slot()->lw(T0, Address(SP, 1 * kWordSize));  // Growable array.
   __ Ret();
   __ delay_slot()->sw(T1,
       FieldAddress(T0, GrowableObjectArray::length_offset()));
   __ Bind(&fall_through);
 }
 
 
 // Set data of growable object array.
 // On stack: growable array (+1), data (+0).
 void Intrinsifier::GrowableList_setData(Assembler* assembler) {
   if (FLAG_enable_type_checks) {
     return;
   }
   Label fall_through;
   __ lw(T1, Address(SP, 0 * kWordSize));  // Data.
   // Check that data is an ObjectArray.
-  __ andi(CMPRES, T1, Immediate(kSmiTagMask));
-  __ beq(CMPRES, ZR, &fall_through);  // Data is Smi.
+  __ andi(CMPRES1, T1, Immediate(kSmiTagMask));
+  __ beq(CMPRES1, ZR, &fall_through);  // Data is Smi.
   __ LoadClassId(CMPRES1, T1);
   __ BranchNotEqual(CMPRES1, kArrayCid, &fall_through);
   __ lw(T0, Address(SP, 1 * kWordSize));  // Growable array.
   __ StoreIntoObject(T0,
                      FieldAddress(T0, GrowableObjectArray::data_offset()),
                      T1);
   __ Ret();
   __ Bind(&fall_through);
 }
 
@@ skipping 31 matching lines @@
   __ Bind(&fall_through);
 }
 
 
 #define TYPED_ARRAY_ALLOCATION(type_name, cid, max_len, scale_shift)           \
   Label fall_through;                                                          \
   const intptr_t kArrayLengthStackOffset = 0 * kWordSize;                      \
   __ lw(T2, Address(SP, kArrayLengthStackOffset));  /* Array length. */        \
   /* Check that length is a positive Smi. */                                   \
   /* T2: requested array length argument. */                                   \
-  __ andi(CMPRES, T2, Immediate(kSmiTagMask));                                 \
-  __ bne(CMPRES, ZR, &fall_through);                                           \
+  __ andi(CMPRES1, T2, Immediate(kSmiTagMask));                                \
+  __ bne(CMPRES1, ZR, &fall_through);                                          \
   __ BranchSignedLess(T2, 0, &fall_through);                                   \
   __ SmiUntag(T2);                                                             \
   /* Check for maximum allowed length. */                                      \
   /* T2: untagged array length. */                                             \
   __ BranchSignedGreater(T2, max_len, &fall_through);                          \
   __ sll(T2, T2, scale_shift);                                                 \
   const intptr_t fixed_size = sizeof(Raw##type_name) + kObjectAlignment - 1;   \
   __ AddImmediate(T2, fixed_size);                                             \
   __ LoadImmediate(TMP, -kObjectAlignment);                                    \
   __ and_(T2, T2, TMP);                                                        \
   Heap* heap = Isolate::Current()->heap();                                     \
                                                                                \
   __ LoadImmediate(V0, heap->TopAddress());                                    \
   __ lw(V0, Address(V0, 0));                                                   \
                                                                                \
   /* T2: allocation size. */                                                   \
-  __ AdduDetectOverflow(T1, V0, T2, CMPRES);                                   \
-  __ bltz(CMPRES, &fall_through);                                              \
+  __ AdduDetectOverflow(T1, V0, T2, CMPRES1);                                  \
+  __ bltz(CMPRES1, &fall_through);                                             \
                                                                                \
   /* Check if the allocation fits into the remaining space. */                 \
   /* V0: potential new object start. */                                        \
   /* T1: potential next object start. */                                       \
   /* T2: allocation size. */                                                   \
   __ LoadImmediate(T3, heap->EndAddress());                                    \
   __ lw(T3, Address(T3, 0));                                                   \
   __ BranchUnsignedGreaterEqual(T1, T3, &fall_through);                        \
                                                                                \
   /* Successfully allocated the object(s), now update top to point to */       \
@@ skipping 84 matching lines @@
 }
 CLASS_LIST_TYPED_DATA(TYPED_DATA_ALLOCATOR)
 #undef TYPED_DATA_ALLOCATOR
 
 
 // Loads args from stack into T0 and T1
 // Tests if they are smis, jumps to label not_smi if not.
 static void TestBothArgumentsSmis(Assembler* assembler, Label* not_smi) {
   __ lw(T0, Address(SP, 0 * kWordSize));
   __ lw(T1, Address(SP, 1 * kWordSize));
-  __ or_(CMPRES, T0, T1);
-  __ andi(CMPRES, CMPRES, Immediate(kSmiTagMask));
-  __ bne(CMPRES, ZR, not_smi);
+  __ or_(CMPRES1, T0, T1);
+  __ andi(CMPRES1, CMPRES1, Immediate(kSmiTagMask));
+  __ bne(CMPRES1, ZR, not_smi);
   return;
 }
 
 
 void Intrinsifier::Integer_addFromInteger(Assembler* assembler) {
   Label fall_through;
 
   TestBothArgumentsSmis(assembler, &fall_through);  // Checks two Smis.
-  __ AdduDetectOverflow(V0, T0, T1, CMPRES);  // Add.
-  __ bltz(CMPRES, &fall_through);  // Fall through on overflow.
+  __ AdduDetectOverflow(V0, T0, T1, CMPRES1);  // Add.
+  __ bltz(CMPRES1, &fall_through);  // Fall through on overflow.
   __ Ret();  // Nothing in branch delay slot.
   __ Bind(&fall_through);
 }
 
 
 void Intrinsifier::Integer_add(Assembler* assembler) {
   return Integer_addFromInteger(assembler);
 }
 
 
 void Intrinsifier::Integer_subFromInteger(Assembler* assembler) {
   Label fall_through;
 
   TestBothArgumentsSmis(assembler, &fall_through);
-  __ SubuDetectOverflow(V0, T0, T1, CMPRES);  // Subtract.
-  __ bltz(CMPRES, &fall_through);  // Fall through on overflow.
+  __ SubuDetectOverflow(V0, T0, T1, CMPRES1);  // Subtract.
+  __ bltz(CMPRES1, &fall_through);  // Fall through on overflow.
   __ Ret();
   __ Bind(&fall_through);
 }
 
 
 void Intrinsifier::Integer_sub(Assembler* assembler) {
   Label fall_through;
 
   TestBothArgumentsSmis(assembler, &fall_through);
-  __ SubuDetectOverflow(V0, T1, T0, CMPRES);  // Subtract.
-  __ bltz(CMPRES, &fall_through);  // Fall through on overflow.
+  __ SubuDetectOverflow(V0, T1, T0, CMPRES1);  // Subtract.
+  __ bltz(CMPRES1, &fall_through);  // Fall through on overflow.
   __ Ret();  // Nothing in branch delay slot.
   __ Bind(&fall_through);
 }
 
 
 void Intrinsifier::Integer_mulFromInteger(Assembler* assembler) {
   Label fall_through;
 
   TestBothArgumentsSmis(assembler, &fall_through);  // checks two smis
   __ SmiUntag(T0);  // untags T0. only want result shifted by one
@@ skipping 58 matching lines @@
 //      res = res - right;
 //    } else {
 //      res = res + right;
 //    }
 //  }
 void Intrinsifier::Integer_moduloFromInteger(Assembler* assembler) {
   Label fall_through, subtract;
   // Test arguments for smi.
   __ lw(T1, Address(SP, 0 * kWordSize));
   __ lw(T0, Address(SP, 1 * kWordSize));
-  __ or_(CMPRES, T0, T1);
-  __ andi(CMPRES, CMPRES, Immediate(kSmiTagMask));
-  __ bne(CMPRES, ZR, &fall_through);
+  __ or_(CMPRES1, T0, T1);
+  __ andi(CMPRES1, CMPRES1, Immediate(kSmiTagMask));
+  __ bne(CMPRES1, ZR, &fall_through);
   // T1: Tagged left (dividend).
   // T0: Tagged right (divisor).
   // Check if modulo by zero -> exception thrown in main function.
   __ beq(T0, ZR, &fall_through);
   EmitRemainderOperation(assembler);
   // Untagged right in T0. Untagged remainder result in V0.
 
   Label done;
   __ bgez(V0, &done);
   __ bltz(T0, &subtract);
@@ skipping 48 matching lines @@
   __ Ret();
   __ delay_slot()->SmiTag(V0);
   __ Bind(&fall_through);
 }
 
 
 void Intrinsifier::Integer_negate(Assembler* assembler) {
   Label fall_through;
 
   __ lw(T0, Address(SP, + 0 * kWordSize));  // Grabs first argument.
-  __ andi(CMPRES, T0, Immediate(kSmiTagMask));  // Test for Smi.
-  __ bne(CMPRES, ZR, &fall_through);  // Fall through if not a Smi.
-  __ SubuDetectOverflow(V0, ZR, T0, CMPRES);
-  __ bltz(CMPRES, &fall_through);  // There was overflow.
+  __ andi(CMPRES1, T0, Immediate(kSmiTagMask));  // Test for Smi.
+  __ bne(CMPRES1, ZR, &fall_through);  // Fall through if not a Smi.
+  __ SubuDetectOverflow(V0, ZR, T0, CMPRES1);
+  __ bltz(CMPRES1, &fall_through);  // There was overflow.
   __ Ret();
   __ Bind(&fall_through);
 }
 
 
 void Intrinsifier::Integer_bitAndFromInteger(Assembler* assembler) {
   Label fall_through;
 
   TestBothArgumentsSmis(assembler, &fall_through);  // Checks two smis.
   __ Ret();
@@ skipping 86 matching lines @@
   __ Bind(&fall_through);
 }
 
 
 static void Get64SmiOrMint(Assembler* assembler,
                            Register res_hi,
                            Register res_lo,
                            Register reg,
                            Label* not_smi_or_mint) {
   Label not_smi, done;
-  __ andi(CMPRES, reg, Immediate(kSmiTagMask));
-  __ bne(CMPRES, ZR, &not_smi);
+  __ andi(CMPRES1, reg, Immediate(kSmiTagMask));
+  __ bne(CMPRES1, ZR, &not_smi);
   __ SmiUntag(reg);
 
   // Sign extend to 64 bit
   __ mov(res_lo, reg);
   __ b(&done);
   __ delay_slot()->sra(res_hi, reg, 31);
 
   __ Bind(&not_smi);
   __ LoadClassId(CMPRES1, reg);
   __ BranchNotEqual(CMPRES1, kMintCid, not_smi_or_mint);
@@ skipping 106 matching lines @@
 // This is called for Smi, Mint and Bigint receivers. The right argument
 // can be Smi, Mint, Bigint or double.
 void Intrinsifier::Integer_equalToInteger(Assembler* assembler) {
   Label fall_through, true_label, check_for_mint;
   // For integer receiver '===' check first.
   __ lw(T0, Address(SP, 0 * kWordSize));
   __ lw(T1, Address(SP, 1 * kWordSize));
   __ beq(T0, T1, &true_label);
 
   __ or_(T2, T0, T1);
-  __ andi(CMPRES, T2, Immediate(kSmiTagMask));
+  __ andi(CMPRES1, T2, Immediate(kSmiTagMask));
   // If T0 or T1 is not a smi do Mint checks.
-  __ bne(CMPRES, ZR, &check_for_mint);
+  __ bne(CMPRES1, ZR, &check_for_mint);
 
   // Both arguments are smi, '===' is good enough.
   __ LoadObject(V0, Bool::False());
   __ Ret();
   __ Bind(&true_label);
   __ LoadObject(V0, Bool::True());
   __ Ret();
 
   // At least one of the arguments was not Smi.
   Label receiver_not_smi;
   __ Bind(&check_for_mint);
 
-  __ andi(CMPRES, T1, Immediate(kSmiTagMask));
-  __ bne(CMPRES, ZR, &receiver_not_smi);  // Check receiver.
+  __ andi(CMPRES1, T1, Immediate(kSmiTagMask));
+  __ bne(CMPRES1, ZR, &receiver_not_smi);  // Check receiver.
 
   // Left (receiver) is Smi, return false if right is not Double.
   // Note that an instance of Mint or Bigint never contains a value that can be
   // represented by Smi.
 
   __ LoadClassId(CMPRES1, T0);
   __ BranchEqual(CMPRES1, kDoubleCid, &fall_through);
   __ LoadObject(V0, Bool::False());  // Smi == Mint -> false.
   __ Ret();
 
   __ Bind(&receiver_not_smi);
   // T1:: receiver.
 
   __ LoadClassId(CMPRES1, T1);
   __ BranchNotEqual(CMPRES1, kMintCid, &fall_through);
   // Receiver is Mint, return false if right is Smi.
-  __ andi(CMPRES, T0, Immediate(kSmiTagMask));
-  __ bne(CMPRES, ZR, &fall_through);
+  __ andi(CMPRES1, T0, Immediate(kSmiTagMask));
+  __ bne(CMPRES1, ZR, &fall_through);
   __ LoadObject(V0, Bool::False());
   __ Ret();
   // TODO(srdjan): Implement Mint == Mint comparison.
 
   __ Bind(&fall_through);
 }
 
 
 void Intrinsifier::Integer_equal(Assembler* assembler) {
   return Integer_equalToInteger(assembler);
 }
 
 
 void Intrinsifier::Integer_sar(Assembler* assembler) {
   Label fall_through;
 
   TestBothArgumentsSmis(assembler, &fall_through);
   // Shift amount in T0. Value to shift in T1.
 
   __ SmiUntag(T0);
   __ bltz(T0, &fall_through);
 
   __ LoadImmediate(T2, 0x1F);
-  __ slt(CMPRES, T2, T0);  // CMPRES <- 0x1F < T0 ? 1 : 0
-  __ movn(T0, T2, CMPRES);  // T0 <- 0x1F < T0 ? 0x1F : T0
+  __ slt(CMPRES1, T2, T0);  // CMPRES1 <- 0x1F < T0 ? 1 : 0
+  __ movn(T0, T2, CMPRES1);  // T0 <- 0x1F < T0 ? 0x1F : T0
 
   __ SmiUntag(T1);
   __ srav(V0, T1, T0);
   __ Ret();
   __ delay_slot()->SmiTag(V0);
   __ Bind(&fall_through);
 }
 
 
 void Intrinsifier::Smi_bitNegate(Assembler* assembler) {
   __ lw(T0, Address(SP, 0 * kWordSize));
   __ nor(V0, T0, ZR);
   __ Ret();
   __ delay_slot()->addiu(V0, V0, Immediate(-1));  // Remove inverted smi-tag.
 }
 
 
 void Intrinsifier::Smi_bitLength(Assembler* assembler) {
   // TODO(sra): Implement.
 }
 
 
 // Check if the last argument is a double, jump to label 'is_smi' if smi
 // (easy to convert to double), otherwise jump to label 'not_double_smi',
 // Returns the last argument in T0.
 static void TestLastArgumentIsDouble(Assembler* assembler,
                                      Label* is_smi,
                                      Label* not_double_smi) {
   __ lw(T0, Address(SP, 0 * kWordSize));
-  __ andi(CMPRES, T0, Immediate(kSmiTagMask));
-  __ beq(CMPRES, ZR, is_smi);
+  __ andi(CMPRES1, T0, Immediate(kSmiTagMask));
+  __ beq(CMPRES1, ZR, is_smi);
   __ LoadClassId(CMPRES1, T0);
   __ BranchNotEqual(CMPRES1, kDoubleCid, not_double_smi);
   // Fall through with Double in T0.
 }
 
 
 // Both arguments on stack, arg0 (left) is a double, arg1 (right) is of unknown
 // type. Return true or false object in the register V0. Any NaN argument
 // returns false. Any non-double arg1 causes control flow to fall through to the
 // slow case (compiled method body).
@@ skipping 120 matching lines @@
 void Intrinsifier::Double_div(Assembler* assembler) {
   return DoubleArithmeticOperations(assembler, Token::kDIV);
 }
 
 
 // Left is double right is integer (Bigint, Mint or Smi)
 void Intrinsifier::Double_mulFromInteger(Assembler* assembler) {
   Label fall_through;
   // Only smis allowed.
   __ lw(T0, Address(SP, 0 * kWordSize));
-  __ andi(CMPRES, T0, Immediate(kSmiTagMask));
-  __ bne(CMPRES, ZR, &fall_through);
+  __ andi(CMPRES1, T0, Immediate(kSmiTagMask));
+  __ bne(CMPRES1, ZR, &fall_through);
 
   // Is Smi.
   __ SmiUntag(T0);
   __ mtc1(T0, F4);
   __ cvtdw(D1, F4);
 
   __ lw(T0, Address(SP, 1 * kWordSize));
   __ lwc1(F0, FieldAddress(T0, Double::value_offset()));
   __ lwc1(F1, FieldAddress(T0, Double::value_offset() + kWordSize));
   __ muld(D0, D0, D1);
   const Class& double_class = Class::Handle(
       Isolate::Current()->object_store()->double_class());
   __ TryAllocate(double_class, &fall_through, V0);  // Result register.
   __ swc1(F0, FieldAddress(V0, Double::value_offset()));
   __ Ret();
   __ delay_slot()->swc1(F1,
                         FieldAddress(V0, Double::value_offset() + kWordSize));
   __ Bind(&fall_through);
 }
 
 
 void Intrinsifier::Double_fromInteger(Assembler* assembler) {
   Label fall_through;
 
   __ lw(T0, Address(SP, 0 * kWordSize));
-  __ andi(CMPRES, T0, Immediate(kSmiTagMask));
+  __ andi(CMPRES1, T0, Immediate(kSmiTagMask));
   __ bne(T0, ZR, &fall_through);
 
   // Is Smi.
   __ SmiUntag(T0);
   __ mtc1(T0, F4);
   __ cvtdw(D0, F4);
   const Class& double_class = Class::Handle(
       Isolate::Current()->object_store()->double_class());
   __ TryAllocate(double_class, &fall_through, V0);  // Result register.
   __ swc1(F0, FieldAddress(V0, Double::value_offset()));
@@ skipping 40 matching lines @@
   __ Ret();
 
   __ Bind(&is_false);
   __ LoadObject(V0, Bool::False());
   __ Ret();
 
   __ Bind(&is_zero);
   // Check for negative zero by looking at the sign bit.
   __ mfc1(T0, F1);  // Moves bits 32...63 of D0 to T0.
   __ srl(T0, T0, 31);  // Get the sign bit down to bit 0 of T0.
-  __ andi(CMPRES, T0, Immediate(1));  // Check if the bit is set.
+  __ andi(CMPRES1, T0, Immediate(1));  // Check if the bit is set.
   __ bne(T0, ZR, &is_true);  // Sign bit set. True.
   __ b(&is_false);
 }
 
 
 void Intrinsifier::Double_toInt(Assembler* assembler) {
   __ lw(T0, Address(SP, 0 * kWordSize));
   __ LoadDFromOffset(D0, T0, Double::value_offset() - kHeapObjectTag);
 
   __ cvtwd(F2, D0);
   __ mfc1(V0, F2);
 
   // Overflow is signaled with minint.
   Label fall_through;
   // Check for overflow and that it fits into Smi.
   __ LoadImmediate(TMP, 0xC0000000);
-  __ subu(CMPRES, V0, TMP);
-  __ bltz(CMPRES, &fall_through);
+  __ subu(CMPRES1, V0, TMP);
+  __ bltz(CMPRES1, &fall_through);
   __ Ret();
   __ delay_slot()->SmiTag(V0);
   __ Bind(&fall_through);
 }
 
 
 void Intrinsifier::Math_sqrt(Assembler* assembler) {
   Label fall_through, is_smi, double_op;
   TestLastArgumentIsDouble(assembler, &is_smi, &fall_through);
   // Argument is double and is in T0.
@@ skipping 104 matching lines @@
 }
 
 
 void Intrinsifier::String_codeUnitAt(Assembler* assembler) {
   Label fall_through, try_two_byte_string;
 
   __ lw(T1, Address(SP, 0 * kWordSize));  // Index.
   __ lw(T0, Address(SP, 1 * kWordSize));  // String.
 
   // Checks.
-  __ andi(CMPRES, T1, Immediate(kSmiTagMask));
+  __ andi(CMPRES1, T1, Immediate(kSmiTagMask));
   __ bne(T1, ZR, &fall_through);  // Index is not a Smi.
   __ lw(T2, FieldAddress(T0, String::length_offset()));  // Range check.
   // Runtime throws exception.
   __ BranchUnsignedGreaterEqual(T1, T2, &fall_through);
   __ LoadClassId(CMPRES1, T0);  // Class ID check.
   __ BranchNotEqual(CMPRES1, kOneByteStringCid, &try_two_byte_string);
 
   // Grab byte and return.
   __ SmiUntag(T1);
   __ addu(T2, T0, T1);
@@ skipping 110 matching lines @@
   __ LoadImmediate(TMP, ~(kObjectAlignment - 1));
   __ and_(length_reg, length_reg, TMP);
 
   Isolate* isolate = Isolate::Current();
   Heap* heap = isolate->heap();
 
   __ LoadImmediate(T3, heap->TopAddress());
   __ lw(V0, Address(T3, 0));
 
   // length_reg: allocation size.
-  __ AdduDetectOverflow(T1, V0, length_reg, CMPRES);
-  __ bltz(CMPRES, failure);  // Fail on overflow.
+  __ AdduDetectOverflow(T1, V0, length_reg, CMPRES1);
+  __ bltz(CMPRES1, failure);  // Fail on overflow.
 
   // Check if the allocation fits into the remaining space.
   // V0: potential new object start.
   // T1: potential next object start.
   // T2: allocation size.
   // T3: heap->TopAddress().
   __ LoadImmediate(T4, heap->EndAddress());
   __ lw(T4, Address(T4, 0));
   __ BranchUnsignedGreaterEqual(T1, T4, failure);
 
@@ skipping 14 matching lines @@
 
     __ BranchUnsignedGreater(T2, RawObject::SizeTag::kMaxSizeTag, &overflow);
     __ b(&done);
     __ delay_slot()->sll(T2, T2, shift);
     __ Bind(&overflow);
     __ mov(T2, ZR);
     __ Bind(&done);
 
     // Get the class index and insert it into the tags.
     // T2: size and bit tags.
-    __ LoadImmediate(TMP1, RawObject::ClassIdTag::encode(cls.id()));
-    __ or_(T2, T2, TMP1);
+    __ LoadImmediate(TMP, RawObject::ClassIdTag::encode(cls.id()));
+    __ or_(T2, T2, TMP);
     __ sw(T2, FieldAddress(V0, String::tags_offset()));  // Store tags.
   }
 
   // Set the length field using the saved length (T6).
   __ StoreIntoObjectNoBarrier(V0,
                               FieldAddress(V0, String::length_offset()),
                               T6);
   // Clear hash.
   __ b(ok);
   __ delay_slot()->sw(ZR, FieldAddress(V0, String::hash_offset()));
 }
 
 
 // Arg0: OneByteString (receiver).
 // Arg1: Start index as Smi.
 // Arg2: End index as Smi.
 // The indexes must be valid.
 void Intrinsifier::OneByteString_substringUnchecked(Assembler* assembler) {
   const intptr_t kStringOffset = 2 * kWordSize;
   const intptr_t kStartIndexOffset = 1 * kWordSize;
   const intptr_t kEndIndexOffset = 0 * kWordSize;
   Label fall_through, ok;
 
   __ lw(T2, Address(SP, kEndIndexOffset));
   __ lw(TMP, Address(SP, kStartIndexOffset));
-  __ or_(CMPRES, T2, TMP);
-  __ andi(CMPRES, CMPRES, Immediate(kSmiTagMask));
-  __ bne(CMPRES, ZR, &fall_through);  // 'start', 'end' not Smi.
+  __ or_(CMPRES1, T2, TMP);
+  __ andi(CMPRES1, CMPRES1, Immediate(kSmiTagMask));
+  __ bne(CMPRES1, ZR, &fall_through);  // 'start', 'end' not Smi.
 
   __ subu(T2, T2, TMP);
   TryAllocateOnebyteString(assembler, &ok, &fall_through);
   __ Bind(&ok);
   // V0: new string as tagged pointer.
   // Copy string.
   __ lw(T3, Address(SP, kStringOffset));
   __ lw(T1, Address(SP, kStartIndexOffset));
   __ SmiUntag(T1);
   __ addu(T3, T3, T1);
@@ skipping 58 matching lines @@
 // TODO(srdjan): Add combinations (one-byte/two-byte/external strings).
 void StringEquality(Assembler* assembler, intptr_t string_cid) {
   Label fall_through, is_true, is_false, loop;
   __ lw(T0, Address(SP, 1 * kWordSize));  // This.
   __ lw(T1, Address(SP, 0 * kWordSize));  // Other.
 
   // Are identical?
   __ beq(T0, T1, &is_true);
 
   // Is other OneByteString?
-  __ andi(CMPRES, T1, Immediate(kSmiTagMask));
-  __ beq(CMPRES, ZR, &fall_through);  // Other is Smi.
+  __ andi(CMPRES1, T1, Immediate(kSmiTagMask));
+  __ beq(CMPRES1, ZR, &fall_through);  // Other is Smi.
   __ LoadClassId(CMPRES1, T1);  // Class ID check.
   __ BranchNotEqual(CMPRES1, string_cid, &fall_through);
 
   // Have same length?
   __ lw(T2, FieldAddress(T0, String::length_offset()));
   __ lw(T3, FieldAddress(T1, String::length_offset()));
   __ bne(T2, T3, &is_false);
 
   // Check contents, no fall-through possible.
   ASSERT((string_cid == kOneByteStringCid) ||
@@ skipping 34 matching lines @@
 }
 
 
 void Intrinsifier::TwoByteString_equality(Assembler* assembler) {
   StringEquality(assembler, kTwoByteStringCid);
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_MIPS