Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 596113002: Make isolated tests work with asan (Closed)

Created:
6 years, 3 months ago by Paweł Hajdan Jr.
Modified:
6 years, 3 months ago
Reviewers:
Nico, M-A Ruel
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M base/base.isolate View 1 chunk +7 lines, -0 lines 0 comments Download
M build/android/pylib/gtest/setup.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M build/isolate.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Paweł Hajdan Jr.
6 years, 3 months ago (2014-09-23 23:12:17 UTC) #2
M-A Ruel
You have to update the android one too at build/android/pylib/gtest/setup.py
6 years, 3 months ago (2014-09-23 23:13:55 UTC) #3
Paweł Hajdan Jr.
On 2014/09/23 23:13:55, M-A Ruel wrote: > You have to update the android one too ...
6 years, 3 months ago (2014-09-23 23:34:04 UTC) #4
M-A Ruel
lgtm
6 years, 3 months ago (2014-09-23 23:37:37 UTC) #5
Nico
lgtm
6 years, 3 months ago (2014-09-23 23:54:08 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/31d267935a2d604dd62b440ee8b36af1c762654c Cr-Commit-Position: refs/heads/master@{#296462}
6 years, 3 months ago (2014-09-24 18:03:27 UTC) #7
Paweł Hajdan Jr.
6 years, 3 months ago (2014-09-24 18:03:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 31d2679 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698