Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3290)

Unified Diff: base/win/scoped_process_information_unittest.cc

Issue 596103002: Fix more disabled MSVC warnings, base/ edition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comment Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/time/time_win_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/win/scoped_process_information_unittest.cc
diff --git a/base/win/scoped_process_information_unittest.cc b/base/win/scoped_process_information_unittest.cc
index ac531cafd036033df9c2fec7ad41ca1ecc1efd81..ccfa7290a972e7ac06f2ed6dcbdf1274f25b44be 100644
--- a/base/win/scoped_process_information_unittest.cc
+++ b/base/win/scoped_process_information_unittest.cc
@@ -69,7 +69,7 @@ TEST_F(ScopedProcessInformationTest, Receive) {
EXPECT_EQ(kThreadId, process_info.thread_id());
EXPECT_EQ(kProcessHandle, process_info.process_handle());
EXPECT_EQ(kThreadHandle, process_info.thread_handle());
- PROCESS_INFORMATION to_discard = process_info.Take();
+ process_info.Take();
}
TEST_F(ScopedProcessInformationTest, TakeProcess) {
@@ -81,7 +81,7 @@ TEST_F(ScopedProcessInformationTest, TakeProcess) {
EXPECT_EQ(NULL, process_info.process_handle());
EXPECT_EQ(0, process_info.process_id());
EXPECT_TRUE(process_info.IsValid());
- PROCESS_INFORMATION to_discard = process_info.Take();
+ process_info.Take();
}
TEST_F(ScopedProcessInformationTest, TakeThread) {
@@ -93,17 +93,17 @@ TEST_F(ScopedProcessInformationTest, TakeThread) {
EXPECT_EQ(NULL, process_info.thread_handle());
EXPECT_EQ(0, process_info.thread_id());
EXPECT_TRUE(process_info.IsValid());
- PROCESS_INFORMATION to_discard = process_info.Take();
+ process_info.Take();
}
TEST_F(ScopedProcessInformationTest, TakeBoth) {
base::win::ScopedProcessInformation process_info;
MockCreateProcess(&process_info);
- HANDLE process = process_info.TakeProcessHandle();
- HANDLE thread = process_info.TakeThreadHandle();
+ process_info.TakeProcessHandle();
+ process_info.TakeThreadHandle();
EXPECT_FALSE(process_info.IsValid());
- PROCESS_INFORMATION to_discard = process_info.Take();
+ process_info.Take();
}
TEST_F(ScopedProcessInformationTest, TakeWholeStruct) {
« no previous file with comments | « base/time/time_win_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698