base/metrics/histogram_base.cc - Issue 596103002: Fix more disabled MSVC warnings, base/ edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/histogram_base.cc

Issue 596103002: Fix more disabled MSVC warnings, base/ edition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comment Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/metrics/histogram_base.cc

diff --git a/base/metrics/histogram_base.cc b/base/metrics/histogram_base.cc

index 6e7e69e061c632858f3bfcc33310d5145cfeb4e1..f09c84e20d0968262c8ec338c8691d9863b3b0d6 100644

--- a/base/metrics/histogram_base.cc

+++ b/base/metrics/histogram_base.cc

@@ -109,7 +109,7 @@ void HistogramBase::WriteJSON(std::string* output) const {

DictionaryValue root;

root.SetString("name", histogram_name());

root.SetInteger("count", count);

- root.SetDouble("sum", sum);

+ root.SetDouble("sum", static_cast<double>(sum));

root.SetInteger("flags", flags());

root.Set("params", parameters.release());

root.Set("buckets", buckets.release());

« no previous file with comments | « base/metrics/histogram.cc ('k') | base/numerics/safe_math.h » ('j') | no next file with comments »