Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Unified Diff: base/files/file_util.cc

Issue 596103002: Fix more disabled MSVC warnings, base/ edition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comment Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/files/file_path_unittest.cc ('k') | base/json/json_parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/files/file_util.cc
diff --git a/base/files/file_util.cc b/base/files/file_util.cc
index 96a7164720d1ee19609135a792aa8fed6cd130b4..17b596946baadcd59928e4ce179c9b0aa25348b8 100644
--- a/base/files/file_util.cc
+++ b/base/files/file_util.cc
@@ -75,7 +75,7 @@ bool ContentsEqual(const FilePath& filename1, const FilePath& filename2) {
if ((file1.eof() != file2.eof()) ||
(file1.gcount() != file2.gcount()) ||
- (memcmp(buffer1, buffer2, file1.gcount()))) {
+ (memcmp(buffer1, buffer2, static_cast<size_t>(file1.gcount())))) {
file1.close();
file2.close();
return false;
« no previous file with comments | « base/files/file_path_unittest.cc ('k') | base/json/json_parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698