Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2277)

Unified Diff: base/file_version_info_win.h

Issue 596103002: Fix more disabled MSVC warnings, base/ edition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comment Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/debug/trace_event_synthetic_delay_unittest.cc ('k') | base/file_version_info_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/file_version_info_win.h
diff --git a/base/file_version_info_win.h b/base/file_version_info_win.h
index d623c45426140aa3651fe397c160df4301799b1f..34bc675977b15cef8875e4b863726899c789c300 100644
--- a/base/file_version_info_win.h
+++ b/base/file_version_info_win.h
@@ -17,7 +17,7 @@ typedef tagVS_FIXEDFILEINFO VS_FIXEDFILEINFO;
class FileVersionInfoWin : public FileVersionInfo {
public:
- BASE_EXPORT FileVersionInfoWin(void* data, int language, int code_page);
+ BASE_EXPORT FileVersionInfoWin(void* data, WORD language, WORD code_page);
BASE_EXPORT ~FileVersionInfoWin();
// Accessors to the different version properties.
@@ -51,8 +51,8 @@ class FileVersionInfoWin : public FileVersionInfo {
private:
scoped_ptr<char, base::FreeDeleter> data_;
- int language_;
- int code_page_;
+ WORD language_;
+ WORD code_page_;
// This is a pointer into the data_ if it exists. Otherwise NULL.
VS_FIXEDFILEINFO* fixed_file_info_;
« no previous file with comments | « base/debug/trace_event_synthetic_delay_unittest.cc ('k') | base/file_version_info_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698