base/test/launcher/test_results_tracker.cc - Issue 596103002: Fix more disabled MSVC warnings, base/ edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/test/launcher/test_results_tracker.cc

Issue 596103002: Fix more disabled MSVC warnings, base/ edition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't assume char (un)signedness Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/test/launcher/test_results_tracker.cc

diff --git a/base/test/launcher/test_results_tracker.cc b/base/test/launcher/test_results_tracker.cc

index 1e3b2b059470c26bdb32c5b27cbf66d664113557..b553fd6b51e9b80e1a681d9f563f2e5f930ea996 100644

--- a/base/test/launcher/test_results_tracker.cc

+++ b/base/test/launcher/test_results_tracker.cc

@@ -288,7 +288,8 @@ bool TestResultsTracker::SaveSummaryAsJSON(const FilePath& path) const {

test_result_value->SetString("status", test_result.StatusAsString());

test_result_value->SetInteger(

- "elapsed_time_ms", test_result.elapsed_time.InMilliseconds());

+ "elapsed_time_ms",

+ static_cast<int>(test_result.elapsed_time.InMilliseconds()));

// There are no guarantees about character encoding of the output

// snippet. Escape it and record whether it was losless.