base/strings/utf_string_conversion_utils.cc - Issue 596103002: Fix more disabled MSVC warnings, base/ edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/strings/utf_string_conversion_utils.cc

Issue 596103002: Fix more disabled MSVC warnings, base/ edition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/strings/utf_string_conversion_utils.cc

diff --git a/base/strings/utf_string_conversion_utils.cc b/base/strings/utf_string_conversion_utils.cc

index 09a003d1b9cedc509e9fb8ec86371c5a2e0aa31f..022c0dffd895ab7defaff9c482b7228b1e7e9b3a 100644

--- a/base/strings/utf_string_conversion_utils.cc

+++ b/base/strings/utf_string_conversion_utils.cc

@@ -71,7 +71,7 @@ bool ReadUnicodeCharacter(const wchar_t* src,

size_t WriteUnicodeCharacter(uint32 code_point, std::string* output) {

if (code_point <= 0x7f) {

// Fast path the common case of one byte.

- output->push_back(code_point);

+ output->push_back(static_cast<char>(code_point));

return 1;

}