base/strings/string_number_conversions.cc - Issue 596103002: Fix more disabled MSVC warnings, base/ edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/strings/string_number_conversions.cc

Issue 596103002: Fix more disabled MSVC warnings, base/ edition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/strings/string_number_conversions.cc

diff --git a/base/strings/string_number_conversions.cc b/base/strings/string_number_conversions.cc

index d6bd5c48070cfbba527be002734352284e10dcc8..642d24e9ada11ad61444fcadd81a0accddb0df65 100644

--- a/base/strings/string_number_conversions.cc

+++ b/base/strings/string_number_conversions.cc

@@ -103,7 +103,7 @@ template<typename CHAR, int BASE> class BaseCharToDigit<CHAR, BASE, true> {

public:

static bool Convert(CHAR c, uint8* digit) {

if (c >= '0' && c < '0' + BASE) {

- *digit = c - '0';

+ *digit = static_cast<uint8>(c - '0');

return true;

}

return false;