Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: base/metrics/field_trial_unittest.cc

Issue 596103002: Fix more disabled MSVC warnings, base/ edition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/metrics/field_trial_unittest.cc
diff --git a/base/metrics/field_trial_unittest.cc b/base/metrics/field_trial_unittest.cc
index a6dee1132c5b65bf914685dc0c9be39d14037eed..581803378eb99e15846526692ff77b6150b017f5 100644
--- a/base/metrics/field_trial_unittest.cc
+++ b/base/metrics/field_trial_unittest.cc
@@ -112,7 +112,7 @@ TEST_F(FieldTrialTest, AbsoluteProbabilities) {
char default_always_true[] = " default always true";
char always_false[] = " always false";
char default_always_false[] = " default always false";
- for (int i = 1; i < 250; ++i) {
+ for (char i = 1; i < 250; ++i) {
// Try lots of names, by changing the first character of the name.
always_true[0] = i;
default_always_true[0] = i;
@@ -189,7 +189,7 @@ TEST_F(FieldTrialTest, MiddleProbabilities) {
char default_group_name[] = " default same name";
bool false_event_seen = false;
bool true_event_seen = false;
- for (int i = 1; i < 250; ++i) {
+ for (char i = 1; i < 250; ++i) {
name[0] = i;
default_group_name[0] = i;
scoped_refptr<FieldTrial> trial =
« base/logging.h ('K') | « base/logging_win.cc ('k') | base/metrics/histogram.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698