Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Unified Diff: media/base/android/media_source_player.cc

Issue 596093002: Let audio wait for video to finish prerolling after seek (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressing comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/android/media_source_player.h ('k') | media/base/android/media_source_player_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/android/media_source_player.cc
diff --git a/media/base/android/media_source_player.cc b/media/base/android/media_source_player.cc
index 10717b2ca5ec5c04157f386e9edca683639c8e3b..1c5ebe1cbb2e2b70034d1ea4ded26fd9607d9a33 100644
--- a/media/base/android/media_source_player.cc
+++ b/media/base/android/media_source_player.cc
@@ -44,6 +44,7 @@ MediaSourcePlayer::MediaSourcePlayer(
is_waiting_for_key_(false),
is_waiting_for_audio_decoder_(false),
is_waiting_for_video_decoder_(false),
+ prerolling_(false),
weak_factory_(this) {
audio_decoder_job_.reset(new AudioDecoderJob(
base::Bind(&DemuxerAndroid::RequestDemuxerData,
@@ -346,6 +347,7 @@ void MediaSourcePlayer::OnDemuxerSeekDone(
audio_decoder_job_->BeginPrerolling(preroll_timestamp_);
if (HasVideo())
video_decoder_job_->BeginPrerolling(preroll_timestamp_);
+ prerolling_ = true;
if (!doing_browser_seek_)
manager()->OnSeekComplete(player_id(), current_time);
@@ -509,6 +511,14 @@ void MediaSourcePlayer::MediaDecoderCallback(
if (status == MEDIA_CODEC_STOPPED)
return;
+ if (prerolling_ && IsPrerollFinished(is_audio)) {
+ if (IsPrerollFinished(!is_audio)) {
+ prerolling_ = false;
+ StartInternal();
+ }
+ return;
+ }
+
if (is_clock_manager) {
// If we have a valid timestamp, start the starvation callback. Otherwise,
// reset the |start_time_ticks_| so that the next frame will not suffer
@@ -526,6 +536,12 @@ void MediaSourcePlayer::MediaDecoderCallback(
DecodeMoreVideo();
}
+bool MediaSourcePlayer::IsPrerollFinished(bool is_audio) const {
+ if (is_audio)
+ return !HasAudio() || !audio_decoder_job_->prerolling();
+ return !HasVideo() || !video_decoder_job_->prerolling();
+}
+
void MediaSourcePlayer::DecodeMoreAudio() {
DVLOG(1) << __FUNCTION__;
DCHECK(!audio_decoder_job_->is_decoding());
@@ -589,11 +605,11 @@ void MediaSourcePlayer::ClearDecodingData() {
start_time_ticks_ = base::TimeTicks();
}
-bool MediaSourcePlayer::HasVideo() {
+bool MediaSourcePlayer::HasVideo() const {
return video_decoder_job_->HasStream();
}
-bool MediaSourcePlayer::HasAudio() {
+bool MediaSourcePlayer::HasAudio() const {
return audio_decoder_job_->HasStream();
}
« no previous file with comments | « media/base/android/media_source_player.h ('k') | media/base/android/media_source_player_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698