Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 596083002: Update cryptotoken to 0.8.63 (Closed)

Created:
6 years, 3 months ago by Arnar Birgisson
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update cryptotoken to 0.8.63 - Request batch attestation instead of individual - Updates from U2F API revisions - Enumerate HID devieces based on usage page instead of vid/pid - Handle wrong keyHandle length and init messages - Smaller bug fixes and refactoring BUG=416998 R=xiyuan,juanlang Committed: https://crrev.com/6fb1f2e798c05bc01f3feeb8ae17dbb34f482f86 Cr-Commit-Position: refs/heads/master@{#296334}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unnecessary permission from manifest #

Patch Set 3 : Remove a deprecated line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+394 lines, -130 lines) Patch
M chrome/browser/resources/component_extension_resources.grd View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/cryptotoken/cryptotokenbackground.js View 1 chunk +7 lines, -31 lines 0 comments Download
M chrome/browser/resources/cryptotoken/devicefactoryregistry.js View 2 chunks +12 lines, -1 line 0 comments Download
M chrome/browser/resources/cryptotoken/devicestatuscodes.js View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/cryptotoken/enroller.js View 1 2 11 chunks +76 lines, -22 lines 0 comments Download
M chrome/browser/resources/cryptotoken/gnubby-u2f.js View 1 chunk +9 lines, -10 lines 0 comments Download
A chrome/browser/resources/cryptotoken/googlecorpindividualattest.js View 1 chunk +41 lines, -0 lines 0 comments Download
M chrome/browser/resources/cryptotoken/hidgnubbydevice.js View 4 chunks +24 lines, -10 lines 0 comments Download
A chrome/browser/resources/cryptotoken/individualattest.js View 1 chunk +24 lines, -0 lines 0 comments Download
M chrome/browser/resources/cryptotoken/manifest.json View 1 6 chunks +19 lines, -4 lines 0 comments Download
M chrome/browser/resources/cryptotoken/multiplesigner.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/cryptotoken/signer.js View 9 chunks +31 lines, -10 lines 0 comments Download
M chrome/browser/resources/cryptotoken/singlesigner.js View 8 chunks +19 lines, -15 lines 0 comments Download
M chrome/browser/resources/cryptotoken/textfetcher.js View 3 chunks +16 lines, -4 lines 0 comments Download
M chrome/browser/resources/cryptotoken/usbenrollhandler.js View 2 chunks +9 lines, -5 lines 0 comments Download
M chrome/browser/resources/cryptotoken/usbgnubbydevice.js View 4 chunks +19 lines, -5 lines 0 comments Download
M chrome/browser/resources/cryptotoken/webrequest.js View 4 chunks +79 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Arnar Birgisson
Hi Xiyuan, Juan! Here's the latest refresh of cryptotoken, please have a look. cheers, Arnar
6 years, 3 months ago (2014-09-23 21:01:36 UTC) #1
juanlang (chromium.org)
https://codereview.chromium.org/596083002/diff/1/chrome/browser/resources/cryptotoken/manifest.json File chrome/browser/resources/cryptotoken/manifest.json (right): https://codereview.chromium.org/596083002/diff/1/chrome/browser/resources/cryptotoken/manifest.json#newcode70 chrome/browser/resources/cryptotoken/manifest.json:70: "https://ca-service.corp.google.com/*" I'm pretty sure this isn't necessary for the ...
6 years, 3 months ago (2014-09-23 21:11:47 UTC) #3
Arnar Birgisson
https://codereview.chromium.org/596083002/diff/1/chrome/browser/resources/cryptotoken/manifest.json File chrome/browser/resources/cryptotoken/manifest.json (right): https://codereview.chromium.org/596083002/diff/1/chrome/browser/resources/cryptotoken/manifest.json#newcode70 chrome/browser/resources/cryptotoken/manifest.json:70: "https://ca-service.corp.google.com/*" On 2014/09/23 21:11:47, juanlang (chromium.org) wrote: > I'm ...
6 years, 3 months ago (2014-09-23 22:04:50 UTC) #4
juanlang (chromium.org)
On 2014/09/23 22:04:50, Arnar Birgisson wrote: > https://codereview.chromium.org/596083002/diff/1/chrome/browser/resources/cryptotoken/manifest.json > File chrome/browser/resources/cryptotoken/manifest.json (right): > > https://codereview.chromium.org/596083002/diff/1/chrome/browser/resources/cryptotoken/manifest.json#newcode70 ...
6 years, 3 months ago (2014-09-23 22:10:01 UTC) #5
xiyuan
lgtm
6 years, 3 months ago (2014-09-23 22:15:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596083002/20001
6 years, 3 months ago (2014-09-23 23:12:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596083002/40001
6 years, 3 months ago (2014-09-24 01:27:48 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 1a750f40b4501d937276db344b43844505262bd0
6 years, 3 months ago (2014-09-24 02:59:29 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 03:00:11 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6fb1f2e798c05bc01f3feeb8ae17dbb34f482f86
Cr-Commit-Position: refs/heads/master@{#296334}

Powered by Google App Engine
This is Rietveld 408576698