Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 596053004: Move mojo/edk gyp targets in to mojo/edk/mojo_edk.gyp (Closed)

Created:
6 years, 2 months ago by jamesr
Modified:
6 years, 2 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@mojo_public_gyp
Project:
chromium
Visibility:
Public.

Description

Move mojo/edk gyp targets in to mojo/edk/mojo_edk.gyp R=viettrungluu@chromium.org TBR=darin@chromium.org for updates to various gyp files to point to moved targets Committed: https://crrev.com/777e37d8d95e282d7e3bef85a6cdac46ccef570d Cr-Commit-Position: refs/heads/master@{#298560}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : GN fixes #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+523 lines, -645 lines) Patch
M build/all.gyp View 1 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_app.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M device/device_tests.gyp View 1 chunk +1 line, -1 line 0 comments Download
M extensions/extensions.gyp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/app_shell.gyp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ipc/mojo/ipc_mojo.gyp View 3 chunks +3 lines, -3 lines 0 comments Download
M media/media.gyp View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mojo/application_manager/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mojo/apps/js/test/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mojo/bindings/js/tests/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D mojo/common/test/BUILD.gn View 1 chunk +0 lines, -46 lines 0 comments Download
D mojo/common/test/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D mojo/common/test/run_all_perftests.cc View 1 chunk +0 lines, -14 lines 0 comments Download
D mojo/common/test/run_all_unittests.cc View 1 chunk +0 lines, -26 lines 0 comments Download
D mojo/common/test/test_support_impl.h View 1 chunk +0 lines, -33 lines 0 comments Download
D mojo/common/test/test_support_impl.cc View 1 chunk +0 lines, -72 lines 0 comments Download
A mojo/edk/mojo_edk.gyp View 1 2 3 4 1 chunk +405 lines, -0 lines 0 comments Download
M mojo/edk/system/BUILD.gn View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/test/BUILD.gn View 2 chunks +44 lines, -1 line 0 comments Download
A + mojo/edk/test/run_all_perftests.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/edk/test/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/edk/test/test_support_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/edk/test/test_support_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo.gyp View 8 chunks +10 lines, -9 lines 0 comments Download
M mojo/mojo_apps.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/mojo_base.gyp View 1 2 3 4 6 chunks +4 lines, -381 lines 0 comments Download
M mojo/mojo_nacl.gyp View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo_services.gypi View 5 chunks +6 lines, -6 lines 0 comments Download
M mojo/mojo_variables.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/c/system/tests/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/application/tests/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/environment/tests/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/system/tests/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/utility/tests/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/clipboard/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/cpp/surfaces/tests/BUILD.gn View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
M mojo/services/public/cpp/view_manager/tests/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/keyboard.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
jamesr
Depends on https://codereview.chromium.org/632853002/
6 years, 2 months ago (2014-10-06 23:57:24 UTC) #1
viettrungluu
lgtm
6 years, 2 months ago (2014-10-07 00:42:24 UTC) #2
jamesr
6 years, 2 months ago (2014-10-07 07:05:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596053004/40001
6 years, 2 months ago (2014-10-07 08:39:18 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/5629) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/22356)
6 years, 2 months ago (2014-10-07 08:48:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596053004/60001
6 years, 2 months ago (2014-10-07 17:03:29 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/76105) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/65460) win_gpu ...
6 years, 2 months ago (2014-10-07 17:08:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596053004/80001
6 years, 2 months ago (2014-10-07 18:31:30 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:80001) as 721bde0f8e870f5e45e15a658d92043254610e40
6 years, 2 months ago (2014-10-07 20:31:53 UTC) #15
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 20:32:32 UTC) #16
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/777e37d8d95e282d7e3bef85a6cdac46ccef570d
Cr-Commit-Position: refs/heads/master@{#298560}

Powered by Google App Engine
This is Rietveld 408576698