chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js - Issue 596033002: Entering / exiting dialog notification should not interrupt live region.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js

Issue 596033002: Entering / exiting dialog notification should not interrupt live region. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@event_watcher_tests

Patch Set: Enum, and better test Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher_test.unitjs ('k') | chrome/browser/resources/chromeos/chromevox/chromevox/injected/navigation_manager.js » ('j') | chrome/browser/resources/chromeos/chromevox/host/testing/tts.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js

diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js

index baaa6ae3319c3880f890a611bf6d774651d87222..c72efde8aa2c311181c40f039a57f328b23548f1 100644

--- a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js

+++ b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js

@@ -408,7 +408,7 @@ cvox.LiveRegions.announceChange = function(

// interrupt other live regions but not anything else.

navDescriptions.forEach(function(desc) {

if (!desc.category) {

- desc.category = 'live';

+ desc.category = cvox.TtsCategory.LIVE;

}

});

@@ -432,7 +432,7 @@ cvox.LiveRegions.announceChange = function(

});

navDescriptions = [new cvox.NavDescription({

text: allStrings.join(', '),

- category: 'live'

+ category: cvox.TtsCategory.LIVE

})];

}