Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1135)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 59603009: Removed GetActiveEntry from several tabs related files in chrome/browser/ui.

Created:
7 years, 1 month ago by jww
Modified:
6 years, 11 months ago
CC:
chromium-reviews, tim+watch_chromium.org, tfarina, rsimha+watch_chromium.org, haitaol+watch_chromium.org
Visibility:
Public.

Description

Removed GetActiveEntry from several tabs related files in chrome/browser/ui. See https://codereview.chromium.org/66993003/ for relevant LGTMs. BUG=273710 TBR=creis@chromium.org,sky@chromium.org,pinkerton@chromium.org

Patch Set 1 #

Patch Set 2 : Rebase on ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M chrome/browser/ui/cocoa/applescript/tab_applescript.mm View 1 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/sync/tab_contents_synced_tab_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/tabs/pinned_tab_codec.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
jww
7 years, 1 month ago (2013-11-16 04:59:42 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 1 month ago (2013-11-16 05:01:25 UTC) #2
Charlie Reis
I think you meant sky rather than skg. :) LGTM.
7 years, 1 month ago (2013-11-16 19:17:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jww@chromium.org/59603009/1
7 years, 1 month ago (2013-11-19 22:05:26 UTC) #4
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=190516
7 years, 1 month ago (2013-11-20 03:23:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jww@chromium.org/59603009/1
7 years, 1 month ago (2013-11-21 00:22:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jww@chromium.org/59603009/1
7 years, 1 month ago (2013-11-21 01:39:48 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=191195
7 years, 1 month ago (2013-11-21 04:51:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jww@chromium.org/59603009/430001
6 years, 11 months ago (2014-01-06 20:02:05 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242076
6 years, 11 months ago (2014-01-06 23:50:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jww@chromium.org/59603009/430001
6 years, 11 months ago (2014-01-07 00:05:28 UTC) #11
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=208435
6 years, 11 months ago (2014-01-07 12:53:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jww@chromium.org/59603009/430001
6 years, 11 months ago (2014-01-07 17:54:27 UTC) #13
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 21:58:29 UTC) #14 
Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698