chrome/common/extensions/permissions/chrome_api_permissions.cc - Issue 596003002: Allow declarative webrequest and webrequest in extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/chrome_api_permissions.cc

Issue 596003002: Allow declarative webrequest and webrequest in extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Small changes are made accoding to Ken's comments. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/chrome_extensions_client.cc ('k') | chrome/common/extensions_api_resources.grd » ('j') | extensions/browser/api/declarative/declarative_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/permissions/chrome_api_permissions.cc

diff --git a/chrome/common/extensions/permissions/chrome_api_permissions.cc b/chrome/common/extensions/permissions/chrome_api_permissions.cc

index 14c557806aa7cc3a2bc86fc3f803533e8621c616..aa1f1f5cec9a807f36737e1fd80d8c6821ee3888 100644

--- a/chrome/common/extensions/permissions/chrome_api_permissions.cc

+++ b/chrome/common/extensions/permissions/chrome_api_permissions.cc

@@ -38,10 +38,6 @@ std::vector<APIPermissionInfo*> ChromeAPIPermissions::GetAllPermissions()

PermissionMessage::kClipboard},

{APIPermission::kClipboardWrite, "clipboardWrite"},

{APIPermission::kDeclarativeContent, "declarativeContent"},

- {APIPermission::kDeclarativeWebRequest, "declarativeWebRequest",

- APIPermissionInfo::kFlagNone,

- IDS_EXTENSION_PROMPT_WARNING_DECLARATIVE_WEB_REQUEST,

- PermissionMessage::kDeclarativeWebRequest},

{APIPermission::kDesktopCapture, "desktopCapture",

APIPermissionInfo::kFlagNone,

IDS_EXTENSION_PROMPT_WARNING_DESKTOP_CAPTURE,

@@ -151,8 +147,6 @@ std::vector<APIPermissionInfo*> ChromeAPIPermissions::GetAllPermissions()

{APIPermission::kWebNavigation, "webNavigation",

APIPermissionInfo::kFlagNone, IDS_EXTENSION_PROMPT_WARNING_HISTORY_READ,

PermissionMessage::kTabs},

- {APIPermission::kWebRequest, "webRequest"},

- {APIPermission::kWebRequestBlocking, "webRequestBlocking"},

// Register private permissions.

{APIPermission::kScreenlockPrivate, "screenlockPrivate",