Extend JSBuiltinReducer to cover Math.sqrt as well.

Extend JSBuiltinReducer to cover Math.sqrt as well.

R=bmeurer@chromium.org
TEST=compiler-unittests/JSBuiltinReducerTest.MathSqrt

Committed: https://code.google.com/p/v8/source/detail?r=24177

[Benedikt Meurer, 2014-09-24 06:34:43]

Please add PURE(Float64Sqrt,1,1) to machine-operator-unittest.cc as well.

https://codereview.chromium.org/595963002/diff/1/src/compiler/js-builtin-redu...
File src/compiler/js-builtin-reducer-unittest.cc (right):

https://codereview.chromium.org/595963002/diff/1/src/compiler/js-builtin-redu...
src/compiler/js-builtin-reducer-unittest.cc:76: EXPECT_TRUE(r.Changed());
Nit: use ASSERT_TRUE, doesn't make sense to do the EXPECT_THAT below if it
didn't change.

[Michael Starzinger, 2014-09-24 08:20:51]

Addressed comments. PTAL.

https://codereview.chromium.org/595963002/diff/1/src/compiler/js-builtin-redu...
File src/compiler/js-builtin-reducer-unittest.cc (right):

https://codereview.chromium.org/595963002/diff/1/src/compiler/js-builtin-redu...
src/compiler/js-builtin-reducer-unittest.cc:76: EXPECT_TRUE(r.Changed());
On 2014/09/24 06:34:43, Benedikt Meurer wrote:
> Nit: use ASSERT_TRUE, doesn't make sense to do the EXPECT_THAT below if it
> didn't change.

Done, here and at all occurrences below.

[Benedikt Meurer, 2014-09-24 09:30:08]

LGTM

[Michael Starzinger, 2014-09-24 10:24:42]

Committed patchset #2 (id:20001) manually as 24177 (presubmit successful).