Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 595943002: WebTestInterfaces class to chromium c++ style. (Closed)

Created:
6 years, 3 months ago by Abhishek
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, Jitu( very slow this week), jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

WebTestInterfaces class to chromium c++ style. BUG=331299 Committed: https://crrev.com/bdd07a89ef7a571cefde72549c9d3287b09a27a8 Cr-Commit-Position: refs/heads/master@{#296667}

Patch Set 1 #

Total comments: 2

Patch Set 2 : resolved comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -185 lines) Patch
M content/content_shell.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/renderer/shell_content_renderer_client.cc View 6 chunks +8 lines, -7 lines 0 comments Download
M content/shell/renderer/shell_render_frame_observer.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M content/shell/renderer/shell_render_process_observer.cc View 3 chunks +4 lines, -4 lines 0 comments Download
D content/shell/renderer/test_runner/WebTestInterfaces.h View 1 chunk +0 lines, -61 lines 0 comments Download
D content/shell/renderer/test_runner/WebTestInterfaces.cpp View 1 chunk +0 lines, -92 lines 0 comments Download
A content/shell/renderer/test_runner/web_test_interfaces.h View 1 1 chunk +67 lines, -0 lines 0 comments Download
A content/shell/renderer/test_runner/web_test_interfaces.cc View 1 chunk +81 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M content/shell/renderer/webkit_test_runner.cc View 7 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Abhishek
PTAL !
6 years, 3 months ago (2014-09-23 14:43:02 UTC) #2
jochen (gone - plz use gerrit)
lgtm with nit https://codereview.chromium.org/595943002/diff/1/content/shell/renderer/test_runner/web_test_interfaces.h File content/shell/renderer/test_runner/web_test_interfaces.h (right): https://codereview.chromium.org/595943002/diff/1/content/shell/renderer/test_runner/web_test_interfaces.h#newcode61 content/shell/renderer/test_runner/web_test_interfaces.h:61: }; nit. DISALLOW_COPY_AND_ASSIGN()
6 years, 3 months ago (2014-09-24 20:00:27 UTC) #3
Abhishek
https://codereview.chromium.org/595943002/diff/1/content/shell/renderer/test_runner/web_test_interfaces.h File content/shell/renderer/test_runner/web_test_interfaces.h (right): https://codereview.chromium.org/595943002/diff/1/content/shell/renderer/test_runner/web_test_interfaces.h#newcode61 content/shell/renderer/test_runner/web_test_interfaces.h:61: }; On 2014/09/24 20:00:27, jochen (slow for reviews) wrote: ...
6 years, 3 months ago (2014-09-25 05:37:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595943002/20001
6 years, 3 months ago (2014-09-25 05:37:50 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as cb38af54559c2d6bfc01f3b74b25b9c0a22e0a99
6 years, 2 months ago (2014-09-25 06:34:17 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 06:34:52 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/bdd07a89ef7a571cefde72549c9d3287b09a27a8
Cr-Commit-Position: refs/heads/master@{#296667}

Powered by Google App Engine
This is Rietveld 408576698