Declaring the weak_ptr_factory in proper order in src/net.

net/proxy/proxy_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/proxy/proxy_service.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 539 matching lines @@
   //                      script's contents have changed.
   //   |net_log| the NetLog to log progress into.
   ProxyScriptDeciderPoller(ChangeCallback callback,
                            const ProxyConfig& config,
                            bool proxy_resolver_expects_pac_bytes,
                            ProxyScriptFetcher* proxy_script_fetcher,
                            DhcpProxyScriptFetcher* dhcp_proxy_script_fetcher,
                            int init_net_error,
                            ProxyResolverScriptData* init_script_data,
                            NetLog* net_log)
-      : weak_factory_(this),
-        change_callback_(callback),
+      : change_callback_(callback),
         config_(config),
         proxy_resolver_expects_pac_bytes_(proxy_resolver_expects_pac_bytes),
         proxy_script_fetcher_(proxy_script_fetcher),
         dhcp_proxy_script_fetcher_(dhcp_proxy_script_fetcher),
         last_error_(init_net_error),
         last_script_data_(init_script_data),
-        last_poll_time_(TimeTicks::Now()) {
+        last_poll_time_(TimeTicks::Now()),
+        weak_factory_(this) {
     // Set the initial poll delay.
     next_poll_mode_ = poll_policy()->GetNextDelay(
         last_error_, TimeDelta::FromSeconds(-1), &next_poll_delay_);
     TryToStartNextPoll(false);
   }
 
   void OnLazyPoll() {
     // We have just been notified of network activity. Use this opportunity to
     // see if we can start our next poll.
     TryToStartNextPoll(true);
@@ skipping 108 matching lines @@
   }
 
   void NotifyProxyServiceOfChange(
       int result,
       const scoped_refptr<ProxyResolverScriptData>& script_data,
       const ProxyConfig& effective_config) {
     // Note that |this| may be deleted after calling into the ProxyService.
     change_callback_.Run(result, script_data.get(), effective_config);
   }
 
-  base::WeakPtrFactory<ProxyScriptDeciderPoller> weak_factory_;
-
   ChangeCallback change_callback_;
   ProxyConfig config_;
   bool proxy_resolver_expects_pac_bytes_;
   ProxyScriptFetcher* proxy_script_fetcher_;
   DhcpProxyScriptFetcher* dhcp_proxy_script_fetcher_;
 
   int last_error_;
   scoped_refptr<ProxyResolverScriptData> last_script_data_;
 
   scoped_ptr<ProxyScriptDecider> decider_;
   TimeDelta next_poll_delay_;
   PacPollPolicy::Mode next_poll_mode_;
 
   TimeTicks last_poll_time_;
 
   // Polling policy injected by unit-tests. Otherwise this is NULL and the
   // default policy will be used.
   static const PacPollPolicy* poll_policy_;
 
   const DefaultPollPolicy default_poll_policy_;
 
   bool quick_check_enabled_;
 
+  base::WeakPtrFactory<ProxyScriptDeciderPoller> weak_factory_;
+
   DISALLOW_COPY_AND_ASSIGN(ProxyScriptDeciderPoller);
 };
 
 // static
 const ProxyService::PacPollPolicy*
     ProxyService::ProxyScriptDeciderPoller::poll_policy_ = NULL;
 
 // ProxyService::PacRequest ---------------------------------------------------
 
 class ProxyService::PacRequest
@@ skipping 824 matching lines @@
   State previous_state = ResetProxyConfig(false);
   if (previous_state != STATE_NONE)
     ApplyProxyConfigIfAvailable();
 }
 
 void ProxyService::OnDNSChanged() {
   OnIPAddressChanged();
 }
 
 }  // namespace net