Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 595913003: Declaring the weak_ptr_factory in proper order in src/net. (Closed)

Created:
6 years, 3 months ago by nagarjuna.a
Modified:
6 years, 2 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Declaring the weak_ptr_factory in proper order in src/net. Cleaning up weak_ptr_factory destruction order. WeakPtrFactory should remain the last member so it'll be destroyed and invalidate its weak pointers before any other members are destroyed. BUG=303818 Committed: https://crrev.com/541ad2c748eda43323ef93cae62ed3974f3a330c Cr-Commit-Position: refs/heads/master@{#298402}

Patch Set 1 #

Patch Set 2 : Added entry in AUTHORS file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/proxy/proxy_service.cc View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
nagarjuna.a
agl@chromium.org: Please review changes in darin@chromium.org: Please review changes in PTAL
6 years, 3 months ago (2014-09-23 14:45:27 UTC) #2
agl
I don't think that AUTHORS is the correct file to add. If you're doing this ...
6 years, 3 months ago (2014-09-24 20:36:05 UTC) #3
nagarjuna.a
On 2014/09/24 20:36:05, agl wrote: > I don't think that AUTHORS is the correct file ...
6 years, 2 months ago (2014-10-01 05:10:58 UTC) #6
agl
LGTM. Ok, it does seem that Samsung people are listed as individuals in AUTHORS.
6 years, 2 months ago (2014-10-06 18:18:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595913003/20001
6 years, 2 months ago (2014-10-06 18:21:03 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered_tests/builds/55098)
6 years, 2 months ago (2014-10-06 23:30:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595913003/20001
6 years, 2 months ago (2014-10-07 06:13:37 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 1bf7db499e273ae9867b0d8d58b9e488be7cf7e9
6 years, 2 months ago (2014-10-07 06:14:38 UTC) #16
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 06:15:10 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/541ad2c748eda43323ef93cae62ed3974f3a330c
Cr-Commit-Position: refs/heads/master@{#298402}

Powered by Google App Engine
This is Rietveld 408576698