Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 595913002: [Android] Avoid setting update_draw_properties. (Closed)

Created:
6 years, 3 months ago by MuVen
Modified:
6 years, 3 months ago
Reviewers:
danakj, wjmaclean
CC:
chromium-reviews, cc-bugs_chromium.org, Sikugu_
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Avoid setting update_draw_properties. While setting up the scrollbar layer if the properties of the scrollbar layer didn't change, then avoid setting update_draw_properties. Scrollbar needs animation if any of the scrollbar properties changed. In the same way set update_draw_properties if scrollbar properties are changed. Committed: https://crrev.com/7acc4b3e5a0815bd781eafc1c4d1d69163d61e60 Cr-Commit-Position: refs/heads/master@{#296193}

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -17 lines) Patch
M cc/layers/layer_impl.cc View 1 1 chunk +18 lines, -17 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
MuVen
PTAL.
6 years, 3 months ago (2014-09-23 14:00:42 UTC) #2
wjmaclean
https://codereview.chromium.org/595913002/diff/1/cc/layers/layer_impl.cc File cc/layers/layer_impl.cc (right): https://codereview.chromium.org/595913002/diff/1/cc/layers/layer_impl.cc#newcode1300 cc/layers/layer_impl.cc:1300: // TODO(wjmaclean) The scrollbar animator for the pinch-zoom scrollbars ...
6 years, 3 months ago (2014-09-23 14:30:13 UTC) #4
danakj
LGTM % wjmaclean
6 years, 3 months ago (2014-09-23 14:38:39 UTC) #5
MuVen
On 2014/09/23 14:38:39, danakj wrote: > LGTM % wjmaclean PTAL.
6 years, 3 months ago (2014-09-23 14:43:56 UTC) #6
MuVen
PTAL. https://codereview.chromium.org/595913002/diff/1/cc/layers/layer_impl.cc File cc/layers/layer_impl.cc (right): https://codereview.chromium.org/595913002/diff/1/cc/layers/layer_impl.cc#newcode1300 cc/layers/layer_impl.cc:1300: // TODO(wjmaclean) The scrollbar animator for the pinch-zoom ...
6 years, 3 months ago (2014-09-23 14:44:09 UTC) #7
wjmaclean
lgtm
6 years, 3 months ago (2014-09-23 14:46:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595913002/20001
6 years, 3 months ago (2014-09-23 14:48:11 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as fbe6e79638a4cc0a967302f730335f3ce7b76e93
6 years, 3 months ago (2014-09-23 15:37:27 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 15:38:05 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7acc4b3e5a0815bd781eafc1c4d1d69163d61e60
Cr-Commit-Position: refs/heads/master@{#296193}

Powered by Google App Engine
This is Rietveld 408576698