Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 595903003: Fix refreshing the volume list when the volume is unmounted. (Closed)

Created:
6 years, 2 months ago by mtomasz
Modified:
6 years, 2 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix refreshing the volume list when the volume is unmounted. When a volume is unmounted, while it was selected, then the list model is updated, and since there is no selection anymore, the current entry from the directory model is selected. However, the corresponding VolumeInfo is gone so we can't call resolveRootEntry(). This patch adds a check. If the volume is gone, then the selection is aborted. TEST=Tested manually with FSP. BUG=418513 Committed: https://crrev.com/4b84385dafb109ba1cd8e2f78366d3585ddbe059 Cr-Commit-Position: refs/heads/master@{#297188}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ui/file_manager/file_manager/foreground/js/directory_tree.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mtomasz
@fukino: PTAL at this tiny patch. Thanks!
6 years, 2 months ago (2014-09-29 11:26:11 UTC) #2
fukino
On 2014/09/29 11:26:11, mtomasz wrote: > @fukino: PTAL at this tiny patch. Thanks! lgtm. Thank ...
6 years, 2 months ago (2014-09-29 16:08:13 UTC) #3
mtomasz
On 2014/09/29 16:08:13, fukino wrote: > On 2014/09/29 11:26:11, mtomasz wrote: > > @fukino: PTAL ...
6 years, 2 months ago (2014-09-29 16:19:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595903003/1
6 years, 2 months ago (2014-09-29 16:19:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as f5ca0ed29deea2886878f5770cf36d4d9b2d273f
6 years, 2 months ago (2014-09-29 16:32:13 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 16:32:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b84385dafb109ba1cd8e2f78366d3585ddbe059
Cr-Commit-Position: refs/heads/master@{#297188}

Powered by Google App Engine
This is Rietveld 408576698