|
|
Created:
6 years, 3 months ago by v8-autoroll Modified:
6 years, 3 months ago CC:
chromium-reviews, Jakob Kummerow, pdr., wjmaclean Base URL:
https://chromium.googlesource.com/chromium/src.git@master Project:
chromium Visibility:
Public. |
DescriptionUpdate V8 to version 3.29.84 (based on bleeding_edge revision r24096).
TBR=machenbach@chromium.org
Committed: https://crrev.com/0c4993f41cd0dcdb344dbedfc902bcf69bf2eac1
Cr-Commit-Position: refs/heads/master@{#296179}
Patch Set 1 #Messages
Total messages: 17 (4 generated)
The CQ bit was checked by v8-autoroll@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595883002/1
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
lgtm
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595883002/1
FYI - trying again with a revision before the layout test timeouts started. With a bit of a risk, because they're quite flaky.
On 2014/09/23 13:21:30, Michael Achenbach wrote: > FYI - trying again with a revision before the layout test timeouts started. With > a bit of a risk, because they're quite flaky. Sounds good to me. Let's see how that goes. Thanks for the heads up.
On 2014/09/23 13:22:34, Mads Ager (chromium) wrote: > On 2014/09/23 13:21:30, Michael Achenbach wrote: > > FYI - trying again with a revision before the layout test timeouts started. > With > > a bit of a risk, because they're quite flaky. > > Sounds good to me. Let's see how that goes. Thanks for the heads up. +pdr +wjmaclean FYI, as it looks like landing this is going to go later than my Blink gardening shift. The previous roll made http/tests/serviceworker/request.html time out on ia32 targets (mac, windows, linux32).
ager@chromium.org changed reviewers: + ager@chromium.org
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 709bbe51b2376abab203757ff7db3d5ab548dd9f
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/0c4993f41cd0dcdb344dbedfc902bcf69bf2eac1 Cr-Commit-Position: refs/heads/master@{#296179}
Message was sent while issue was closed.
This still tickled something in that serviceworker/request.html test. It is timing out in release mode ia32 and it is hitting an assert in debug mode ia32. I updated the status file for the test while this is investigated. See http://crbug.com/409755.
Message was sent while issue was closed.
On 2014/09/24 06:23:08, Mads Ager (chromium) wrote: > This still tickled something in that serviceworker/request.html test. > > It is timing out in release mode ia32 and it is hitting an assert in debug mode > ia32. I updated the status file for the test while this is investigated. See > http://crbug.com/409755. Awesome, thanks for not reverting! The reason why we didn't detect this: The test is new and was added after the last v8 roll. The test fails also on our waterfall, but it seemed to be at an innocent V8 revision (because the test just appeared). Our sheriff will investigate and probably find the culprit between the last rolled v8 revision and the first one failing. |