Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 595883002: Update V8 to version 3.29.84 (based on bleeding_edge revision r24096). (Closed)

Created:
6 years, 3 months ago by v8-autoroll
Modified:
6 years, 3 months ago
CC:
chromium-reviews, Jakob Kummerow, pdr., wjmaclean
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update V8 to version 3.29.84 (based on bleeding_edge revision r24096). TBR=machenbach@chromium.org Committed: https://crrev.com/0c4993f41cd0dcdb344dbedfc902bcf69bf2eac1 Cr-Commit-Position: refs/heads/master@{#296179}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (4 generated)
v8-autoroll
6 years, 3 months ago (2014-09-23 13:03:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595883002/1
6 years, 3 months ago (2014-09-23 13:04:10 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-23 13:04:12 UTC) #5
Michael Achenbach
lgtm
6 years, 3 months ago (2014-09-23 13:19:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595883002/1
6 years, 3 months ago (2014-09-23 13:20:29 UTC) #8
Michael Achenbach
FYI - trying again with a revision before the layout test timeouts started. With a ...
6 years, 3 months ago (2014-09-23 13:21:30 UTC) #9
Mads Ager (chromium)
On 2014/09/23 13:21:30, Michael Achenbach wrote: > FYI - trying again with a revision before ...
6 years, 3 months ago (2014-09-23 13:22:34 UTC) #10
Mads Ager (chromium)
On 2014/09/23 13:22:34, Mads Ager (chromium) wrote: > On 2014/09/23 13:21:30, Michael Achenbach wrote: > ...
6 years, 3 months ago (2014-09-23 14:21:36 UTC) #11
Mads Ager (chromium)
6 years, 3 months ago (2014-09-23 14:22:00 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as 709bbe51b2376abab203757ff7db3d5ab548dd9f
6 years, 3 months ago (2014-09-23 14:31:00 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0c4993f41cd0dcdb344dbedfc902bcf69bf2eac1 Cr-Commit-Position: refs/heads/master@{#296179}
6 years, 3 months ago (2014-09-23 14:31:43 UTC) #15
Mads Ager (chromium)
This still tickled something in that serviceworker/request.html test. It is timing out in release mode ...
6 years, 3 months ago (2014-09-24 06:23:08 UTC) #16
Michael Achenbach
6 years, 3 months ago (2014-09-24 07:03:27 UTC) #17
Message was sent while issue was closed.
On 2014/09/24 06:23:08, Mads Ager (chromium) wrote:
> This still tickled something in that serviceworker/request.html test.
> 
> It is timing out in release mode ia32 and it is hitting an assert in debug
mode
> ia32. I updated the status file for the test while this is investigated. See
> http://crbug.com/409755.

Awesome, thanks for not reverting!

The reason why we didn't detect this: The test is new and was added after the
last v8 roll. The test fails also on our waterfall, but it seemed to be at an
innocent V8 revision (because the test just appeared). Our sheriff will
investigate and probably find the culprit between the last rolled v8 revision
and the first one failing.

Powered by Google App Engine
This is Rietveld 408576698