[webcrypto] Interpret empty BigInteger as 0 according to the spec

[webcrypto] Interpret empty BigInteger as 0 according to the spec

BUG=373552
R=eroman
Tests= crypto/ LayoutTests

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183826

[eroman, 2014-09-24 16:38:51]

This change looks_good!

However before I can approve you must sign the contributor agreement and add
your name to the src/AUTHORS file. The instructions on doing that can be found
here under "Get your Code ready":

http://www.chromium.org/developers/contributing-code

(You can modify your chromium changelist to include src/AUTHORS)

[xun.sun, 2014-09-25 05:26:52]

On 2014/09/24 16:38:51, eroman wrote:
> This change looks_good!
> 
> However before I can approve you must sign the contributor agreement and add
> your name to the src/AUTHORS file. The instructions on doing that can be found
> here under "Get your Code ready":
> 
> http://www.chromium.org/developers/contributing-code
> 
> (You can modify your chromium changelist to include src/AUTHORS)

Done

[eroman, 2014-10-15 03:15:47]

patchset 2 LGTM

[eroman, 2014-10-15 03:15:53]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-10-15 03:16:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/595873003/20001

[commit-bot: I haz the power, 2014-10-15 04:16:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-15 04:16:15]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/2...)

[eroman, 2014-10-15 20:19:12]

Note that this failed to be committed because the test:
  rsa-oaep-generateKey-parseAlgorithm-failures.html

Failed on one of the Linux bots.

The problem is that RSA-OAEP support on Linux is dependent on the version of
system NSS. So this test is failing with an unsupportederror instead of the zero
exponent error.

There are two possible solutions to this problem:

  (1) Mark the test as failing on Linux in LayoutTests/TestExpectations
(https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...)

  (2) Create a new test that does the same thing but using RSA-SSA instead of
RSA-OAEP (since RSA-SSA support is available on all of our Linux test bots).
This is my preferred solution.

 --> Create a new test called rsa-ssa-generateKey-failures.html

Also note that in the name I removed "parseAlgorithm". The test you edited is
supposed to just be testing failures from the Blink side (i.e.
NormalizeAlgorithm.cpp) and not actually calling into code from the Chromium
side (content/child/webcrypto).

Please let me know once the changelist has been updated to address this.

[xun.sun, 2014-10-16 02:16:59]

On 2014/10/15 20:19:12, eroman wrote:
> Note that this failed to be committed because the test:
>   rsa-oaep-generateKey-parseAlgorithm-failures.html
> 
> Failed on one of the Linux bots.
> 
> The problem is that RSA-OAEP support on Linux is dependent on the version of
> system NSS. So this test is failing with an unsupportederror instead of the
zero
> exponent error.
> 
> There are two possible solutions to this problem:
> 
>   (1) Mark the test as failing on Linux in LayoutTests/TestExpectations
>
(https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...)
> 
>   (2) Create a new test that does the same thing but using RSA-SSA instead of
> RSA-OAEP (since RSA-SSA support is available on all of our Linux test bots).
> This is my preferred solution.
> 
>  --> Create a new test called rsa-ssa-generateKey-failures.html

Can I add them to the existing rsa-ssa-generateKey-parseAlgorithm-failures.html?
Seems cleaner.

> 
> Also note that in the name I removed "parseAlgorithm". The test you edited is
> supposed to just be testing failures from the Blink side (i.e.
> NormalizeAlgorithm.cpp) and not actually calling into code from the Chromium
> side (content/child/webcrypto).
> 
> Please let me know once the changelist has been updated to address this.

[eroman, 2014-10-16 03:32:39]

I will accept it added to linux failure list.

[eroman, 2014-10-16 03:33:41]

Er, I meant o say "yes" you can add it to that test and I will accept.

(However strictly speaking it should go in a new test since it isn't a parsing
algorithm failure)

[xun.sun, 2014-10-16 07:40:09]

On 2014/10/16 03:33:41, eroman wrote:
> Er, I meant o say "yes" you can add it to that test and I will accept.
> 
> (However strictly speaking it should go in a new test since it isn't a parsing
> algorithm failure)

Noted after I upload the 3rd patchset...

[eroman, 2014-10-16 14:07:58]

patchset 3 LGTM

[eroman, 2014-10-16 14:08:09]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-10-16 14:09:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/595873003/40001

[commit-bot: I haz the power, 2014-10-16 16:17:25]

Committed patchset #3 (id:40001) as 183826