Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 595863002: Adding more missing deoptimization points in Turbofan. (Closed)

Created:
6 years, 3 months ago by Jarin
Modified:
6 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Adding more missing deoptimization points in Turbofan. BUG= R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24289

Patch Set 1 #

Patch Set 2 : More deopts #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+315 lines, -106 lines) Patch
M src/arm/full-codegen-arm.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M src/ast.h View 1 2 3 chunks +6 lines, -1 line 0 comments Download
M src/compiler/ast-graph-builder.h View 1 4 chunks +10 lines, -6 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 23 chunks +52 lines, -23 lines 0 comments Download
M src/compiler/code-generator.cc View 5 chunks +38 lines, -19 lines 0 comments Download
M src/compiler/common-operator.h View 1 chunk +23 lines, -3 lines 0 comments Download
M src/compiler/common-operator.cc View 1 chunk +44 lines, -0 lines 0 comments Download
M src/compiler/instruction.h View 1 2 1 chunk +13 lines, -16 lines 0 comments Download
M src/compiler/instruction-selector-unittest.cc View 1 2 4 chunks +15 lines, -10 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/linkage.cc View 1 1 chunk +54 lines, -3 lines 0 comments Download
M src/compiler/operator-properties-inl.h View 1 1 chunk +17 lines, -12 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-codegen-deopt.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/big-array-literal.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/debug-references.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-78270.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/strict-mode.js View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jarin
Could you take a look, please?
6 years, 3 months ago (2014-09-23 14:32:46 UTC) #2
Benedikt Meurer
LGTM
6 years, 2 months ago (2014-09-24 07:38:12 UTC) #3
Jarin
6 years, 2 months ago (2014-09-29 13:38:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 24289 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698