Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1397)

Unified Diff: test/cctest/test-heap-profiler.cc

Issue 59583003: Revert "Record allocation stack traces". (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: REBASE Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap-snapshot-generator.cc ('k') | tools/gyp/v8.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-heap-profiler.cc
diff --git a/test/cctest/test-heap-profiler.cc b/test/cctest/test-heap-profiler.cc
index 4544a9f0e0db3babb513d69ce7a743e11be7b657..12638d2eec23b70b3480f047231836aa01a24725 100644
--- a/test/cctest/test-heap-profiler.cc
+++ b/test/cctest/test-heap-profiler.cc
@@ -31,7 +31,6 @@
#include "v8.h"
-#include "allocation-tracker.h"
#include "cctest.h"
#include "hashmap.h"
#include "heap-profiler.h"
@@ -40,12 +39,6 @@
#include "utils-inl.h"
#include "../include/v8-profiler.h"
-using i::AllocationTraceNode;
-using i::AllocationTraceTree;
-using i::AllocationTracker;
-using i::HashMap;
-using i::Vector;
-
namespace {
class NamedEntriesDetector {
@@ -2081,104 +2074,6 @@ TEST(HeapObjectsTracker) {
}
-static const char* record_trace_tree_source =
-"var topFunctions = [];\n"
-"var global = this;\n"
-"function generateFunctions(width, depth) {\n"
-" var script = [];\n"
-" for (var i = 0; i < width; i++) {\n"
-" for (var j = 0; j < depth; j++) {\n"
-" script.push('function f_' + i + '_' + j + '(x) {\\n');\n"
-" script.push(' try {\\n');\n"
-" if (j < depth-2) {\n"
-" script.push(' return f_' + i + '_' + (j+1) + '(x+1);\\n');\n"
-" } else if (j == depth - 2) {\n"
-" script.push(' return new f_' + i + '_' + (depth - 1) + '();\\n');\n"
-" } else if (j == depth - 1) {\n"
-" script.push(' this.ts = Date.now();\\n');\n"
-" }\n"
-" script.push(' } catch (e) {}\\n');\n"
-" script.push('}\\n');\n"
-" \n"
-" }\n"
-" }\n"
-" var script = script.join('');\n"
-" // throw script;\n"
-" global.eval(script);\n"
-" for (var i = 0; i < width; i++) {\n"
-" topFunctions.push(this['f_' + i + '_0']);\n"
-" }\n"
-"}\n"
-"\n"
-"var width = 3;\n"
-"var depth = 3;\n"
-"generateFunctions(width, depth);\n"
-"var instances = [];\n"
-"function start() {\n"
-" for (var i = 0; i < width; i++) {\n"
-" instances.push(topFunctions[i](0));\n"
-" }\n"
-"}\n"
-"\n"
-"for (var i = 0; i < 100; i++) start();\n";
-
-
-static i::HeapSnapshot* ToInternal(const v8::HeapSnapshot* snapshot) {
- return const_cast<i::HeapSnapshot*>(
- reinterpret_cast<const i::HeapSnapshot*>(snapshot));
-}
-
-
-static AllocationTraceNode* FindNode(
- AllocationTracker* tracker, const Vector<const char*>& names) {
- AllocationTraceNode* node = tracker->trace_tree()->root();
- for (int i = 0; node != NULL && i < names.length(); i++) {
- const char* name = names[i];
- Vector<AllocationTraceNode*> children = node->children();
- node = NULL;
- for (int j = 0; j < children.length(); j++) {
- v8::SnapshotObjectId id = children[j]->function_id();
- AllocationTracker::FunctionInfo* info = tracker->GetFunctionInfo(id);
- if (info && strcmp(info->name, name) == 0) {
- node = children[j];
- break;
- }
- }
- }
- return node;
-}
-
-
-TEST(TrackHeapAllocations) {
- v8::HandleScope scope(v8::Isolate::GetCurrent());
- LocalContext env;
-
- v8::HeapProfiler* heap_profiler = env->GetIsolate()->GetHeapProfiler();
- heap_profiler->StartRecordingHeapAllocations();
-
- CompileRun(record_trace_tree_source);
-
- const v8::HeapSnapshot* snapshot = heap_profiler->TakeHeapSnapshot(
- v8::String::New("Test"));
- i::HeapSnapshotsCollection* collection = ToInternal(snapshot)->collection();
- AllocationTracker* tracker = collection->allocation_tracker();
- CHECK_NE(NULL, tracker);
- // Resolve all function locations.
- tracker->PrepareForSerialization();
- // Print for better diagnostics in case of failure.
- tracker->trace_tree()->Print(tracker);
-
- const char* names[] =
- { "(anonymous function)", "start", "f_0_0", "f_0_1", "f_0_2" };
- AllocationTraceNode* node =
- FindNode(tracker, Vector<const char*>(names, ARRAY_SIZE(names)));
- CHECK_NE(NULL, node);
- CHECK_GE(node->allocation_count(), 100);
- CHECK_GE(node->allocation_size(), 4 * node->allocation_count());
- heap_profiler->StopRecordingHeapAllocations();
-}
-
-
static const v8::HeapGraphNode* GetNodeByPath(const v8::HeapSnapshot* snapshot,
const char* path[],
int depth) {
« no previous file with comments | « src/heap-snapshot-generator.cc ('k') | tools/gyp/v8.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698