Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 595793005: [Telemetry] Update arguments printed by ./run_benchmark --list. (Closed)

Created:
6 years, 2 months ago by eakuefner
Modified:
5 years, 11 months ago
Reviewers:
sullivan, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Update arguments printed by ./run_benchmark --list. This CL coordinates with the recipe switchover to chart JSON by changing the Telemetry commands that run_benchmark emits to pass --output-format=chartjson and --upload-results instead of --ouput-format=buildbot. R=sullivan,tonyg

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/telemetry/telemetry/test_runner.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
eakuefner
This change is part of what will need to be done to switch the recipes ...
6 years, 2 months ago (2014-09-25 18:43:16 UTC) #1
tonyg
6 years, 2 months ago (2014-09-25 18:54:06 UTC) #2
On 2014/09/25 18:43:16, eakuefner wrote:
> This change is part of what will need to be done to switch the recipes to use
> chart JSON. There is still a problem that, currently Annie's code wants to
> generate a temporary file and pass that as --output=<temp_file_name> to
> Telemetry.
> 
> Tony, do you know if it will be possible to add additional arguments to
commands
> that are returned by Telemetry before actually passing them to be run, to
> account for this?

Recipes bakes in the idea of one step returning json to be used later (which is
awesome). Check out the pattern that is used for listing perf tests:
https://code.google.com/p/chromium/codesearch#chromium/tools/build/scripts/sl...

Notice how we pass an output file and use it later. We can do the same thing w/
--output and --output-format.

We can pass whatever args we want when we run the tests here:
https://code.google.com/p/chromium/codesearch#chromium/tools/build/scripts/sl...

Powered by Google App Engine
This is Rietveld 408576698