Issue 595793004: Replace #ifdef with #if TARGET_IPHONE_SIMULATOR.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 595793004: Replace #ifdef with #if TARGET_IPHONE_SIMULATOR. (Closed)

Created:
6 years, 2 months ago by lliabraa

Modified:
6 years, 2 months ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews, erikwright+watch_chromium.org, stuartmorgan

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Replace #ifdef with #if TARGET_IPHONE_SIMULATOR. This value is always defined, but only true on iphonesimulator. BUG=417785 Committed: https://crrev.com/7f1cd3a35d2d2d1268b607fc1cf87913d1ab57be Cr-Commit-Position: refs/heads/master@{#296923}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	base/test/test_support_ios.mm	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595793004/1

6 years, 2 months ago (2014-09-26 11:53:14 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as ede28f79d29e4996b52f622c312cc7c8bc302ca7

6 years, 2 months ago (2014-09-26 12:22:16 UTC) #6

commit-bot: I haz the power

6 years, 2 months ago (2014-09-26 12:23:10 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/7f1cd3a35d2d2d1268b607fc1cf87913d1ab57be
Cr-Commit-Position: refs/heads/master@{#296923}