Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Side by Side Diff: Source/modules/screen_orientation/ScreenOrientation.cpp

Issue 595783003: Make ScreenOrientationController a FrameDestructionObserver. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "modules/screen_orientation/ScreenOrientation.h" 6 #include "modules/screen_orientation/ScreenOrientation.h"
7 7
8 #include "bindings/core/v8/ScriptPromise.h" 8 #include "bindings/core/v8/ScriptPromise.h"
9 #include "bindings/core/v8/ScriptPromiseResolver.h" 9 #include "bindings/core/v8/ScriptPromiseResolver.h"
10 #include "core/dom/DOMException.h" 10 #include "core/dom/DOMException.h"
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 // static 86 // static
87 ScreenOrientation* ScreenOrientation::create(LocalFrame* frame) 87 ScreenOrientation* ScreenOrientation::create(LocalFrame* frame)
88 { 88 {
89 ASSERT(frame); 89 ASSERT(frame);
90 90
91 ScreenOrientation* orientation = adoptRefCountedGarbageCollectedWillBeNoop(n ew ScreenOrientation(frame)); 91 ScreenOrientation* orientation = adoptRefCountedGarbageCollectedWillBeNoop(n ew ScreenOrientation(frame));
92 ASSERT(orientation->controller()); 92 ASSERT(orientation->controller());
93 // FIXME: ideally, we would like to provide the ScreenOrientationController 93 // FIXME: ideally, we would like to provide the ScreenOrientationController
94 // the case where it is not defined but for the moment, it is eagerly 94 // the case where it is not defined but for the moment, it is eagerly
95 // created when the LocalFrame is created so we shouldn't be in that 95 // created when the LocalFrame is created so we shouldn't be in that
96 // situtaion. 96 // situation.
97 // In order to create the ScreenOrientationController lazily, we would need 97 // In order to create the ScreenOrientationController lazily, we would need
98 // to be able to access WebFrameClient from modules/. 98 // to be able to access WebFrameClient from modules/.
99 99
100 orientation->controller()->setOrientation(orientation); 100 orientation->controller()->setOrientation(orientation);
101 return orientation; 101 return orientation;
102 } 102 }
103 103
104 ScreenOrientation::ScreenOrientation(LocalFrame* frame) 104 ScreenOrientation::ScreenOrientation(LocalFrame* frame)
105 : DOMWindowProperty(frame) 105 : DOMWindowProperty(frame)
106 , m_type(WebScreenOrientationUndefined) 106 , m_type(WebScreenOrientationUndefined)
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 return ScreenOrientationController::from(*m_frame); 183 return ScreenOrientationController::from(*m_frame);
184 } 184 }
185 185
186 void ScreenOrientation::trace(Visitor* visitor) 186 void ScreenOrientation::trace(Visitor* visitor)
187 { 187 {
188 EventTargetWithInlineData::trace(visitor); 188 EventTargetWithInlineData::trace(visitor);
189 DOMWindowProperty::trace(visitor); 189 DOMWindowProperty::trace(visitor);
190 } 190 }
191 191
192 } // namespace blink 192 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698