tools/gn/parse_tree.h - Issue 595753002: gn: handle continued suffix comments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/parse_tree.h

Issue 595753002: gn: handle continued suffix comments (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-append-comment

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/parse_tree.h

diff --git a/tools/gn/parse_tree.h b/tools/gn/parse_tree.h

index 470a0577dd86f8663ab580d297d7bc4eaa31e402..e3d4e7d7f93fb343c65ecea7c631f96451d065a6 100644

--- a/tools/gn/parse_tree.h

+++ b/tools/gn/parse_tree.h

@@ -39,6 +39,10 @@ class Comments {

void append_suffix(Token c) {

suffix_.push_back(c);

}

+ // Reverse the order of the suffix comments. When walking the tree in

+ // post-order we append suffix comments in reverse order, so this fixes them

+ // up.

+ void ReverseSuffix();

const std::vector<Token>& after() const { return after_; }

void append_after(Token c) {

« no previous file with comments | « no previous file | tools/gn/parse_tree.cc » ('j') | tools/gn/parser_unittest.cc » ('J')